Skip to content

fix(trash): allow to configure the trash retention in hours - #8237

Merged
mejo- merged 2 commits into
mainfrom
fix/configurable_trash_retention
Aug 5, 2026
Merged

fix(trash): allow to configure the trash retention in hours#8237
mejo- merged 2 commits into
mainfrom
fix/configurable_trash_retention

Conversation

@mejo-

@mejo- mejo- commented Aug 4, 2026

Copy link
Copy Markdown
Member

Also change default from 5 minutes to 5 hours. The cronjob was configured to run only once a day anyway, so the deletion took place sometime between 5 minutes and 1 day after the item was trashed.

Assisted-by: OpenCode:claude-fable-5

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits

@mejo- mejo- self-assigned this Aug 4, 2026
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Aug 4, 2026
@mejo- mejo- moved this from 馃Л Planning evaluation (don't pick) to 馃憖 In review in 馃摑 Productivity team Aug 4, 2026
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 198637 was 198420 (+0.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@mejo-
mejo- force-pushed the fix/configurable_trash_retention branch 2 times, most recently from 93f2860 to c1a508e Compare August 5, 2026 09:20
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 198578 was 198420 (+0.07%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

mejo- added 2 commits August 5, 2026 13:43
@mejo-
fix(trash): allow to configure the trash retention in hours
0dc30ec 
Also change default from 5 minutes to 5 hours. The cronjob was
configured to run only once a day anyway, so the deletion took place
sometime between 5 minutes and 1 day after the item was trashed.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5
@mejo-
test(phpunit): fix failing tests
08e8c4e 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
mejo- force-pushed the fix/configurable_trash_retention branch from c1a508e to 08e8c4e Compare August 5, 2026 11:51
@mejo-

mejo- commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

08e8c4e fixes unrelated phpunit failures that got introduced sometime in the past.

@mejo-

mejo- commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

馃悽 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 198642 was 198420 (+0.11%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@mejo-
mejo- merged commit 07b2fad into main Aug 5, 2026
41 checks passed
@mejo-
mejo- deleted the fix/configurable_trash_retention branch August 5, 2026 14:38
@github-project-automation github-project-automation Bot moved this from 馃憖 In review to 鈽戯笍 Done in 馃摑 Productivity team Aug 5, 2026
@backportbot backportbot Bot mentioned this pull request Aug 5, 2026
Merged
@mejo-

mejo- commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@backportbot backportbot Bot mentioned this pull request Aug 5, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes
@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug

Projects

馃摑 Productivity team
Status: 鈽戯笍 Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mejo- @grnd-alt