feature: add search dialog to new tray menu#10331
Conversation
Rello
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
Rello
added
os: 🍎 macOS
|
/backport to stable-34.0 |
Signed-off-by: Rello <github@scherello.de>
Expose isFetchMoreInProgress, hasSearchTerm, hasSearchError, canEditSearch and a computed SearchState enum as model properties, replacing the derived booleans in SearchWindow.qml. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
Add cases for placeholder, skeleton, results, nothing found and search error states, plus the derived boolean properties. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
camilasan
force-pushed
the
feature/SearchDialog
branch
from
4b74b96 to
d7b44af
Compare
|
search feature to be moved into an independent module |
Signed-off-by: Rello <github@scherello.de>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a6a33754f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| visible: !trayWindowMainItem.showAssistantPanel | ||
|
|
||
| anchors.top: trayWindowMainItem.showAssistantPanel ? assistantInputContainer.bottom : trayWindowUnifiedSearchInputContainer.bottom | ||
| anchors.top: trayWindowMainItem.showAssistantPanel ? assistantInputContainer.bottom : trayWindowHeader.bottom |
There was a problem hiding this comment.
When the cross-account sync warning is visible (UserModel.hasSyncErrors for another account and the assistant is not active), it is still anchored below trayWindowHeader, but this changed SyncStatus to start at the same trayWindowHeader.bottom. Since SyncStatus is declared later, it can overlap/cover the warning instead of leaving space for it, making the warning unreadable or hard to click. Anchor the normal tray content below trayWindowSyncWarning.bottom when that warning is visible, as the removed search input used to do.
Useful? React with 👍 / 👎.
|
Artifact containing the AppImage: nextcloud-appimage-pr-10331.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
4 participants
note: double "search" in the header was removed after the screenshot