Check for file provider upload size mismatch - #10369
Merged
Merged
Conversation
Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
i2h3
added
the
feature: 📁 file provider
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 💻 Desktop Clients team
Collaborator
Author
|
/backport to stable-34.0 |
i2h3
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 💻 Desktop Clients team
claucambra
approved these changes
Jul 14, 2026
MockRemoteInterfaceTests.testEnumerate compared the enumerated root file's date against the item's creationDate, but toNKFile() maps modificationDate onto NKFile.date. MockRemoteItem defaults creationDate and modificationDate to two separate Date() calls that are only sometimes identical, so the assertion flaked on CI when the clock ticked between them. Compare against modificationDate, the field the value is actually derived from. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Iva Horn <iva.horn@nextcloud.com>
10 tasks
|
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10369.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
github-project-automation
Bot
moved this from 🏗️ In progress
to ☑️ Done
in 💻 Desktop Clients team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of reliability improvements derived from issues in use with Adobe Creative Cloud.
Previously, we have not even verified for the upload item to be of the same size as the local item. Further paths with checks based on checksums are out of scope for this release because they require significantly more effort including on the server side.
Checklist
AI (if applicable)