Feature/retry failed network requests

src/libsync/abstractnetworkjob.cpp

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include "common/asserts.h"
 #include "networkjobs.h"
 #include "account.h"
 #include "owncloudpropagator.h"
@@ -211,6 +211,12 @@
     }
 
     if (_reply->error() != QNetworkReply::NoError) {
+        if (!_wasRetriedAfterConnectionClosed && _reply->error() == QNetworkReply::RemoteHostClosedError) {
+            qCWarning(lcNetworkJob()) << "Will retry sending the request once when we detect a remote host closed error";
+            _wasRetriedAfterConnectionClosed = true;
+            retry();
+            return;
+        }
 
         if (_account->credentials()->retryIfNeeded(this))
             return;

src/libsync/abstractnetworkjob.h

@@ -6,7 +6,7 @@
 
 #pragma once
 
 #include "owncloudlib.h"
 
 #include "accountfwd.h"
 #include "common/asserts.h"
@@ -210,6 +210,7 @@
     QNetworkReply *addTimer(QNetworkReply *reply);
     bool _ignoreCredentialFailure = false;
     QPointer<QNetworkReply> _reply; // (QPointer because the NetworkManager may be destroyed before the jobs at exit)
+    bool _wasRetriedAfterConnectionClosed = false;
     QString _path;
     QTimer _timer;
     int _redirectCount = 0;

src/libsync/accessmanager.cpp

@@ -1,10 +1,10 @@
 /*
  * SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors
  * SPDX-FileCopyrightText: 2014 ownCloud GmbH
  * SPDX-License-Identifier: GPL-2.0-or-later
  */
 
 #include <QLoggingCategory>
 #include <QNetworkRequest>
 #include <QNetworkReply>
 #include <QNetworkProxy>
@@ -20,6 +20,8 @@
 #include "common/utility.h"
 #include "httplogger.h"
 
+using namespace Qt::StringLiterals;
+
 namespace OCC {
 
 Q_LOGGING_CATEGORY(lcAccessManager, "nextcloud.sync.accessmanager", QtInfoMsg)
@@ -117,6 +119,14 @@
 
     const auto reply = QNetworkAccessManager::createRequest(op, newRequest, outgoingData);
     HttpLogger::logRequest(reply, op, outgoingData);
+    QObject::connect(reply, &QNetworkReply::requestSent, reply, [reply] {
+        qCInfo(lcAccessManager()) << "Request has been sent"
+                                  << reply->url().toString()
+                                  << reply->request().rawHeader("X-Request-ID"_ba)
+                                  << reply->header(QNetworkRequest::ContentTypeHeader).toString()
+                                  << reply->rawHeaderPairs()
+                                  << reply;
+    });
     return reply;
 }