Skip to content

fix(tray): GNOME + AppIndicator compatibility - #10646

Merged
mgallien merged 1 commit into
nextcloud:masterfrom
ivaradi:fix-tray-gnome
Aug 24, 2026
Merged

fix(tray): GNOME + AppIndicator compatibility#10646
mgallien merged 1 commit into
nextcloud:masterfrom
ivaradi:fix-tray-gnome

Conversation

@ivaradi

@ivaradi ivaradi commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

The account submenu does not work in a standard (Ubuntu) GNOME environment, for the following reasons:

  • If the submenu is empty, no aboutToShow event is sent. This patch pre-populates the submenu.
  • If the submenu is updated when handling aboutToShow, it will be closed immediately. This patch causes the event handler to only fetch the activities in this case. It will still enable dynamic updates for KDE, i.e. dataChanged will be called. In case of GNOME, however, the menu is not marked visible, thus the dataChanged handler will not update (and thus close) the menu. However, since the tray menu is built when opening, the contents will be relatively recent even there, though not updating.

Resolves

#10076

Summary

Checklist

AI (if applicable)

@mgallien mgallien left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mgallien

Copy link
Copy Markdown
Collaborator

Close #10644

The account submenu does not work in a standard (Ubuntu) GNOME environment,
for the following reasons:

* If the submenu is empty, no `aboutToShow` event is sent. This patch
  pre-populates the submenu.
* If the submenu is updated when handling `aboutToShow`, it will be
  closed immediately. This patch causes the event handler to only
  fetch the activities in this case. It will still enable dynamic
  updates for KDE, i.e. `dataChanged` will be called. In case of
  GNOME, however, the menu is not marked visible, thus the
  `dataChanged` handler will not update (and thus close) the menu.
  However, since the tray menu is built when opening, the contents
  will be relatively recent even there, though not updating.

Signed-off-by: Istv谩n V谩radi <ivaradi@varadiistvan.hu>
@mgallien

Copy link
Copy Markdown
Collaborator

/backport to stable34.0 please

@github-actions

Copy link
Copy Markdown
Contributor

Artifact containing the AppImage: nextcloud-appimage-pr-10646.zip

Digest: sha256:aaa98824c619fb598f7abb3c189ba7a5bee770439e1c165361fd59c99000e13b

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
mgallien merged commit 1bf15ed into nextcloud:master Aug 24, 2026
20 of 21 checks passed
@backportbot

backportbot Bot commented Aug 24, 2026

Copy link
Copy Markdown

The backport to stable34.0 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable34.0
git pull origin stable34.0

# Create the new backport branch
git checkout -b backport/10646/stable34.0

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b2fbc2a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10646/stable34.0

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/10646/stable34.0')
fatal: not a valid object name: 'origin/stable34.0'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@mgallien

Copy link
Copy Markdown
Collaborator

/backport to stable-34.0 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account submenu (status/folder/settings) does not open from tray menu on GNOME/AppIndicator (Ubuntu), works fine on MATE

3 participants