fix(tray): GNOME + AppIndicator compatibility - #10646
Merged
Merged
Conversation
ivaradi
requested review from
camilasan,
claucambra,
i2h3,
mgallien and
nilsding
as code owners
August 23, 2026 08:12
ivaradi
force-pushed
the
fix-tray-gnome
branch
from
August 23, 2026 08:46
4d98c51 to
777344a
Compare
Collaborator
|
Close #10644 |
8 tasks
The account submenu does not work in a standard (Ubuntu) GNOME environment, for the following reasons: * If the submenu is empty, no `aboutToShow` event is sent. This patch pre-populates the submenu. * If the submenu is updated when handling `aboutToShow`, it will be closed immediately. This patch causes the event handler to only fetch the activities in this case. It will still enable dynamic updates for KDE, i.e. `dataChanged` will be called. In case of GNOME, however, the menu is not marked visible, thus the `dataChanged` handler will not update (and thus close) the menu. However, since the tray menu is built when opening, the contents will be relatively recent even there, though not updating. Signed-off-by: Istv谩n V谩radi <ivaradi@varadiistvan.hu>
mgallien
force-pushed
the
fix-tray-gnome
branch
from
August 24, 2026 09:01
777344a to
7b2fbc2
Compare
mgallien
enabled auto-merge
August 24, 2026 09:01
Collaborator
|
/backport to stable34.0 please |
claucambra
approved these changes
Aug 24, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10646.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
The backport to # Switch to the target branch and update it
git checkout stable34.0
git pull origin stable34.0
# Create the new backport branch
git checkout -b backport/10646/stable34.0
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7b2fbc2a
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10646/stable34.0Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/10646/stable34.0') Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Collaborator
|
/backport to stable-34.0 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account submenu does not work in a standard (Ubuntu) GNOME environment, for the following reasons:
aboutToShowevent is sent. This patch pre-populates the submenu.aboutToShow, it will be closed immediately. This patch causes the event handler to only fetch the activities in this case. It will still enable dynamic updates for KDE, i.e.dataChangedwill be called. In case of GNOME, however, the menu is not marked visible, thus thedataChangedhandler will not update (and thus close) the menu. However, since the tray menu is built when opening, the contents will be relatively recent even there, though not updating.Resolves
#10076
Summary
Checklist
AI (if applicable)