Skip to content

feat(upgrade_to_32): Detail the outline icon style change#13597

Merged
AndyScherzinger merged 1 commit into
masterfrom
feat/32-icon-changes
Sep 4, 2025
Merged

feat(upgrade_to_32): Detail the outline icon style change#13597
AndyScherzinger merged 1 commit into
masterfrom
feat/32-icon-changes

Conversation

@kra-mo
Copy link
Copy Markdown
Member

@kra-mo kra-mo commented Sep 4, 2025

No description provided.

@kra-mo kra-mo force-pushed the feat/32-icon-changes branch from af7e997 to b3cb769 Compare September 4, 2025 11:21
@kra-mo kra-mo added this to the Nextcloud 32 milestone Sep 4, 2025
Copy link
Copy Markdown
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me! @susnux @skjnldsv is this proper for the dev update docs or should anything be adjusted?

@nickvergessen
Copy link
Copy Markdown
Member

Should also adjusted in https://docs.nextcloud.com/server/latest/developer_manual/design/foundations.html#icons I guess, which mentions "filled"

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Sep 4, 2025

/backport to stable32

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Sep 4, 2025

is this proper for the dev update docs or should anything be adjusted?

@jancborchardt Yes just as mentioned by Joas it should also be adjusted in the design section.

@kra-mo kra-mo force-pushed the feat/32-icon-changes branch from b3cb769 to 318583e Compare September 4, 2025 14:17
@kra-mo
Copy link
Copy Markdown
Member Author

kra-mo commented Sep 4, 2025

Done. Please ignore my editor removing trailing whitespace, I noticed after pushing and I don't want to revert something to make it worse :D

Signed-off-by: kramo <git@kramo.page>
@kra-mo kra-mo force-pushed the feat/32-icon-changes branch from 318583e to eafac1b Compare September 4, 2025 14:24
@AndyScherzinger AndyScherzinger merged commit 5a0e77c into master Sep 4, 2025
13 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/32-icon-changes branch September 4, 2025 14:31
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Sep 4, 2025
@nextcloud nextcloud deleted a comment from welcome Bot Sep 4, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants