fix: provide required file parent param#1017
Merged
Merged
Conversation
167405c to
e062c8e
Compare
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
52f2b62 to
3782cec
Compare
individual-it
approved these changes
May 18, 2026
Collaborator
individual-it
left a comment
There was a problem hiding this comment.
That is pretty annoying
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Collaborator
Author
|
Known API test failure: Scenario: Upload a file that just fits into the users quota # /home/runner/work/integration_openproject/integration_openproject/integration_openproject/tests/acceptance/features/api/directUpload.feature:682
Given the quota of user "Carol" has been set to "10 B"
...
And the content of file at "textfile0.txt" for user "Carol" should be "1234567890" # FeatureContext::theContentOfFileAtForUserShouldBe()
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'1234567890'
+'<?xml version="1.0" encoding="utf-8"?>
+<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
+ <s:exception>Sabre\DAV\Exception\ServiceUnavailable</s:exception>
+ <s:message>Could not open file: textfile0.txt (469), file does seem to exist</s:message>
+</d:error>
+' |
8 tasks
saw-jan
added a commit
that referenced
this pull request
May 18, 2026
* fix: provide required file parent param (#1017) * fix: provide required file parent param Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: use provided single nextcloud version as latest Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: use method signature based on NC version Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * fix: php code style Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix API tests Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * chore: fix return type Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * test: fix test version expectation Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * ci: check server ready first Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> * ci: check proper version number Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com> --------- Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getDavPermissionsmethod's param was changed in nextcloud/server#57374This is a breaking change and there's no info if it will be compatible in the NC master branch. See nextcloud/server#57374 (comment)
Related Issue or Workpackage
Screenshots (if appropriate):
Types of changes
Checklist:
CHANGELOG.mdfile