Skip to content

fix: provide required file parent param#1017

Merged
saw-jan merged 8 commits into
masterfrom
fix/adjust-param-changes
May 18, 2026
Merged

fix: provide required file parent param#1017
saw-jan merged 8 commits into
masterfrom
fix/adjust-param-changes

Conversation

@saw-jan
Copy link
Copy Markdown
Collaborator

@saw-jan saw-jan commented May 7, 2026

Description

getDavPermissions method's param was changed in nextcloud/server#57374
This is a breaking change and there's no info if it will be compatible in the NC master branch. See nextcloud/server#57374 (comment)

Related Issue or Workpackage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan force-pushed the fix/adjust-param-changes branch 7 times, most recently from 167405c to e062c8e Compare May 12, 2026 03:53
@saw-jan saw-jan self-assigned this May 12, 2026
saw-jan added 5 commits May 18, 2026 10:11
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@saw-jan saw-jan force-pushed the fix/adjust-param-changes branch from 52f2b62 to 3782cec Compare May 18, 2026 04:26
@saw-jan saw-jan marked this pull request as ready for review May 18, 2026 04:27
@saw-jan saw-jan requested a review from Ashim-Stha May 18, 2026 04:27
@saw-jan saw-jan marked this pull request as draft May 18, 2026 06:48
Copy link
Copy Markdown
Collaborator

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is pretty annoying

saw-jan added 2 commits May 18, 2026 14:34
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@github-actions
Copy link
Copy Markdown

JS Code Coverage

Coverage after merging fix/adjust-param-changes into master will be
92.28%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   adminSettings.js0%0%0%0%1, 1, 10–19, 2–9
   bootstrap.js0%0%0%0%1, 1, 10–12, 2–9
   dashboard.js0%0%0%0%1, 1, 10–19, 2–9
   personalSettings.js0%0%0%0%1, 1, 10–19, 2–9
   projectTab.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–37, 4–9
   reference.js0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–45, 5–9
   utils.js85.92%33.33%50%87.59%12–20, 23–32
src/api
   endpoints.js100%100%100%100%
   settings.js64.71%100%0%73.33%10–11, 14–15
src/components
   AdminSettings.vue96.06%94.74%97.10%96.19%1003–1005, 1025–1028, 568, 568–569, 569, 606–612, 715–716, 720–721, 724–725, 729–730, 740–745, 788–790, 802–805, 818–820, 842–844, 927–929, 964–967
   ErrorLabel.vue100%100%100%100%
   OAuthConnectButton.vue85.82%63.64%100%87.39%49–56, 64–69, 72–76
   PersonalSettings.vue92.02%95.65%90%91.71%133–134, 144–149, 152–161
src/components/admin
   FieldValue.vue100%100%100%100%
   FormAuthMethod.vue98.12%96.88%100%98.12%222–224, 247–250
   FormHeading.vue100%100%100%100%
   FormOpenProjectHost.vue98.87%94.74%100%99.34%167–169, 279
   FormSSOSettings.vue98.57%97.18%96.55%98.91%231–233, 242–243, 358–359
   TermsOfServiceUnsigned.vue100%100%100%100%
   TextInput.vue100%100%100%100%
src/components/icons
   ClippyIcon.vue100%100%100%100%
   OpenProjectIcon.vue100%100%100%100%
src/components/settings
   CheckBox.vue100%100%100%100%
   ErrorNote.vue100%100%100%100%
   SettingsTitle.vue94.74%80%100%95.35%49–53
src/components/tab
   EmptyContent.vue97.46%90.48%100%98.24%107–111
   SearchInput.vue95.31%92.96%94.74%95.78%138–139, 192, 203–208, 267–269, 285–287, 291–296
   WorkPackage.vue86.22%72.50%93.33%87.62%107–116, 129–131, 142–146, 156–158, 176–182, 220, 220–225, 225, 225–236, 81–82
src/constants
   appID.js100%100%100%100%
   links.js100%100%100%100%
   messages.js100%100%100%100%
src/filesPlugin
   filesPlugin.js0%0%0%0%1, 1, 10, 100–109, 11, 110–113, 12–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
src/utils
   workpackageHelper.js89.84%82.14%88.89%92.15%100–102, 156–157, 23–27, 34, 34, 36, 36, 50–52, 54, 54, 54–56, 97–99
src/views
   CreateWorkPackageModal.vue94.18%86.32%90.48%95.43%367–372, 375, 391, 508–511, 516–521, 526–531, 537–540, 543, 559, 559, 600–604, 614–616, 639–640, 648–650, 679–681, 703–705, 714–718
   Dashboard.vue92.96%92.86%82.61%93.77%120–125, 134, 144, 147, 158–160, 214–217, 220–221, 228–232, 67
   LinkMultipleFilesModal.vue99.14%97.56%100%99.32%157–159
   ProjectsTab.vue94.95%94.34%93.75%95.10%104–107, 143, 154–155, 189–199, 248–250

@saw-jan
Copy link
Copy Markdown
Collaborator Author

saw-jan commented May 18, 2026

Known API test failure:

  Scenario: Upload a file that just fits into the users quota                                                                                # /home/runner/work/integration_openproject/integration_openproject/integration_openproject/tests/acceptance/features/api/directUpload.feature:682
    Given the quota of user "Carol" has been set to "10 B"
    ...
    And the content of file at "textfile0.txt" for user "Carol" should be "1234567890"                                                       # FeatureContext::theContentOfFileAtForUserShouldBe()
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
      -'1234567890'
      +'<?xml version="1.0" encoding="utf-8"?>
      +<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
      +  <s:exception>Sabre\DAV\Exception\ServiceUnavailable</s:exception>
      +  <s:message>Could not open file: textfile0.txt (469), file does seem to exist</s:message>
      +</d:error>
      +'

@saw-jan saw-jan marked this pull request as ready for review May 18, 2026 10:05
@saw-jan saw-jan merged commit abf216d into master May 18, 2026
7 of 10 checks passed
@saw-jan saw-jan deleted the fix/adjust-param-changes branch May 18, 2026 10:06
saw-jan added a commit that referenced this pull request May 18, 2026
* fix: provide required file parent param (#1017)

* fix: provide required file parent param

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* fix: use provided single nextcloud version as latest

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* fix: use method signature based on NC version

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* fix: php code style

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: fix API tests

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* chore: fix return type

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* test: fix test version expectation

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: check server ready first

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

* ci: check proper version number

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>

---------

Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants