Skip to content

3134 bug unable to share a document in offline mode #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

3134 bug unable to share a document in offline mode #3136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a40bc2
fix
marinofaggiana Oct 28, 2024
9d4b449
build 3
marinofaggiana Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Nextcloud.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5682,7 +5682,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2;
CURRENT_PROJECT_VERSION = 3;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = NKUJUXUJ3B;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand Down Expand Up @@ -5748,7 +5748,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2;
CURRENT_PROJECT_VERSION = 3;
DEVELOPMENT_TEAM = NKUJUXUJ3B;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
Expand Down
5 changes: 3 additions & 2 deletions iOSClient/Menu/NCCollectionViewCommon+Menu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
let sceneIdentifier = self.controller?.sceneIdentifier else {
return
}
let tableLocalFile = database.getResultsTableLocalFile(predicate: NSPredicate(format: "ocId == %@", metadata.ocId))?.first
let fileExists = NCUtilityFileSystem().fileProviderStorageExists(metadata)
var actions = [NCMenuAction]()
let serverUrl = metadata.serverUrl + "/" + metadata.fileName
var isOffline: Bool = false
Expand Down Expand Up @@ -198,7 +200,7 @@

//
// FAVORITE
// FIXME: PROPPATCH doesn't work

Check warning on line 203 in iOSClient/Menu/NCCollectionViewCommon+Menu.swift

View workflow job for this annotation

GitHub Actions / Lint 

Todo Violation: FIXMEs should be resolved (PROPPATCH doesn't work) (todo)
// https://github.com/nextcloud/files_lock/issues/68
if !metadata.lock {
actions.append(
Expand Down Expand Up @@ -230,8 +232,7 @@
//
// SHARE
//
if NCNetworking.shared.isOnline,
metadata.canShare {
if (NCNetworking.shared.isOnline || (tableLocalFile != nil && fileExists)) && metadata.canShare {
actions.append(.share(selectedMetadatas: [metadata], controller: self.controller, order: 80))
}

Expand Down
1 change: 1 addition & 0 deletions iOSClient/Settings/AutoUpload/NCAutoUploadModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ class NCAutoUploadModel: ObservableObject, ViewOnAppearHandling {
updateAccountProperty(\.autoUploadWWAnVideo, value: newValue)
}

/// Updates the auto-upload favorite only.
func handleAutoUploadFavoritesOnlyChange(newValue: Bool) {
updateAccountProperty(\.autoUploadFavoritesOnly, value: newValue)
if newValue {
Expand Down
Loading