feat: adds drag, drop and pasting of attachments#13136
Conversation
|
Thanks for the feature! Code looks good on a high level. We'll test and review in detail soon. CI is unhappy about the missing sign-off trailer in your commit. |
|
Thanks |
|
hi @steven-mpawulo, i tested it and i am able to drag and drop some files. I cannot drag and drop pdf files. |
|
Hello @GretaD |
|
@GretaD I'm a bit lost here. If attachment-size-limit is not set, the default value is 0, which means the popup never appears.
|
on main we show this warning: https://github.com/nextcloud/mail/blob/main/src/components/ComposerAttachments.vue#L410 can you show the same for drag and drop? |
Am reusing the already existing logic for uploading files. |
GretaD
left a comment
There was a problem hiding this comment.
please fix the lint and sign the commit :)
Let me work on it asap. |
|
hi, i could reproduce the same issues on main, which means that was not your pr but my local env. I am approving the PR :) thanks again |
18e3177 to
ad20a7f
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@steven-mpawulo please squash the two commits into one and look into the failing DCO then we can merge |
Add support for attaching files via drag-and-drop and clipboard paste in the message composer Signed-off-by: steven-mpawulo <stevenmpawulo@gmail.com>
ad20a7f to
16d4a09
Compare




Add support for attaching files via drag-and-drop and clipboard paste in the message composer.
This reuses the existing attachment upload flow to ensure consistent upload handling and validation.
Fixes #12687.