fix: remove beforeunload and resize listener when closing composer#13169
fix: remove beforeunload and resize listener when closing composer#13169steven-mpawulo wants to merge 2 commits into
Conversation
Signed-off-by: steven-mpawulo <stevenmpawulo@gmail.com>
|
Thanks for the fix |
ChristophWurst
left a comment
There was a problem hiding this comment.
I think this needs more refinement. The listeners have to be put back when you start composing the next email.
And saving any draft should be awaited, so the lines have to be pushed down after the if.
|
Ohh, |
23f7247 to
3276703
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
ChristophWurst
left a comment
There was a problem hiding this comment.
Tested and after sending an email I still can not reload without the warning.
Which use case does this fix address?
|
This PR covers the case from #13031 - closing the composer without sending (draft autosaved) where the beforeunload listener wasn't being removed on close. |
|
After #13303 the handling should already improve. Should be tested again. |
Removed beforeunload and resize listeners
Fixes #13031