fix(ui): show favorites section based on the current folder#13221
Merged
Conversation
The visibility of the favorites section was driven by the unified inbox's starred envelopes for regular folders too, while the section itself renders the current folder's starred messages. Folders with starred mail hid the section until something populated the unified inbox list, and folders without starred mail showed an empty section once it was populated. Assisted-by: Claude:claude-fable-5 Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
hamza221
approved these changes
Jul 6, 2026
Contributor
|
/backport to stable5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The visibility of the favorites section was driven by the unified inbox's starred envelopes for regular folders too, while the section itself renders the current folder's starred messages. Folders with starred mail hid the section until something populated the unified inbox list, and folders without starred mail showed an empty section once it was populated.
Assisted-by: Claude:claude-fable-5
Realization from #12953 (comment).
How to test
main: no favs on top unless you navigate to the unified inbox and back (assuming you have favs there)
here: favs are shown on top
🤖 AI (if applicable)