perf: caching a bit missing avatars#13262
Merged
Merged
Conversation
Signed-off-by: Roberto Guido <info@madbob.org>
Contributor
|
Thanks for your PR 👍 |
There was a problem hiding this comment.
Pull request overview
No bugs or security issues found. Looks good to me.
Changes:
- Add a 1-hour HTTP cache (
cacheFor(60 * 60, false, true)) for404 Not Foundresponses fromAvatarsController::image(). - Update the corresponding unit test expectation to match the new caching behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/Controller/AvatarsController.php | Applies 1-hour caching to negative (404) avatar image responses to reduce repeated lookups. |
| tests/Unit/Controller/AvatarControllerTest.php | Adjusts the testGetImageNotFound expected response caching to the new 1-hour value. |
kesselb
approved these changes
Jul 8, 2026
Contributor
|
/backport to stable5.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AvatarsController::url()already caches missing contents for a full day, I've just added one hour cache also inAvatarsController::image().Comments about the interval are welcome: one hour, as suggested in #9073, or one day, as in
AvatarsController::url()?Fixes #9073