External player support#1130
Merged
David-Development merged 2 commits intonextcloud:masterfrom Dec 13, 2022
JFronny:external-player
Merged
External player support#1130David-Development merged 2 commits intonextcloud:masterfrom JFronny:external-player
David-Development merged 2 commits intonextcloud:masterfrom
JFronny:external-player
Conversation
Signed-off-by: JFronny <git@akbvopenfl1.hopto.org>
Member
|
@JFronny Thank you for implementing this feature in such a neat and minimal way. While debugging I noticed that TTS (text to speech) is not working. I refactored the code a little bit and added a few comments. If that's okay with you I'm good with merging this! Thank you again! |
Contributor
Author
|
Getting this merged was my intention when opening this request. Are there any problems currently preventing that? |
Member
|
@JFronny Sorry.. I was waiting for an email with your response - didn't see the thumbs up earlier. Awesome! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for optionally playing podcasts in an external app.
Closes #1094
I'm not really happy with the special casing needed here to handle the different MediaItem types and downloaded podcasts, but it does seem to work.