Skip to content

Bump desugar_jdk_libs from 1.1.6 to 2.0.0#1577

Merged
AndyScherzinger merged 1 commit intomainfrom
dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0
Jan 30, 2023
Merged

Bump desugar_jdk_libs from 1.1.6 to 2.0.0#1577
AndyScherzinger merged 1 commit intomainfrom
dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Sep 16, 2022 •
edited
Loading

Bumps desugar_jdk_libs from 1.1.6 to 2.0.0.

Changelog

Sourced from desugar_jdk_libs's changelog.

Change Log

Version 1.2.2 (2022-08-19)

  • Add support for API level 33.

Version 1.2.1 (2022-07-08)

  • Update to cover all APIs up to API level 32 (API level 33 still unsupported).

Version 1.2.0 (2022-06-21)

  • Release based on JDK-11. Require AGP version 7.3.0-beta03 or later (Android Studio 2021.3.1).
  • support for all java.util methods added in API level 31 (classes java.util.Duration and java.util.LocalTime).
  • Support for all methods on java.util.concurrent.ConcurrentHashMap.
  • Added class java.util.concurrent.Flow.

Version 1.1.8 (2022-08-19)

Same as in version 1.2.2 above.

Version 1.1.7 (2022-07-08)

Same as in version 1.2.1 above.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 16, 2022
@dependabot dependabot Bot mentioned this pull request Sep 16, 2022
Closed
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 3 times, most recently from 855880a to 9ce1873 Compare September 28, 2022 13:55
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 3 times, most recently from f7281d4 to 7963318 Compare October 3, 2022 14:44
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 3 times, most recently from ddfdbdc to d5d0ea1 Compare October 14, 2022 13:39
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 3 times, most recently from 3874fcc to 424b8ef Compare October 25, 2022 14:54
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 3 times, most recently from dadad1e to dc26b56 Compare November 15, 2022 13:18
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch from dc26b56 to 09965b7 Compare November 21, 2022 08:09
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch from 09965b7 to 32633aa Compare December 8, 2022 14:24
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 2 times, most recently from ad8dd2d to 038cde3 Compare December 20, 2022 13:33
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 2 times, most recently from 0a0fcd0 to bd91a8f Compare December 29, 2022 13:18
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch 4 times, most recently from 574d172 to ef2880b Compare January 16, 2023 14:21
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch from ef2880b to e2f8fdc Compare January 26, 2023 19:44
@tobiasKaminsky
Copy link
Copy Markdown
Member

tobiasKaminsky commented Jan 27, 2023

@AlvaroBrey this allows to run/use jdk 11 code.
In long run I would like to have a common compile/dependency set for all Android apps.

Turns out that we do not set any sourceCompatibility in Files…

@AlvaroBrey
Copy link
Copy Markdown
Member

AlvaroBrey commented Jan 27, 2023

@AlvaroBrey this allows to run/use jdk 11 code.

🤷 We should be moving everything over to Kotlin progressively anyway

In long run I would like to have a common compile/dependency set for all Android apps.

Turns out that we do not set any sourceCompatibility in Files…

I vaguely remember it was set to 1_8 and removed when bumping compileSdk a while ago, but I can't find the PR. I guess we could set it to java 11 at this point

@AndyScherzinger
Copy link
Copy Markdown
Member

AndyScherzinger commented Jan 28, 2023

@dependabot rebase

@dependabot
Bump desugar_jdk_libs from 1.1.6 to 2.0.0
510f7ed 
Bumps [desugar_jdk_libs](https://github.com/google/desugar_jdk_libs) from 1.1.6 to 2.0.0.
- [Release notes](https://github.com/google/desugar_jdk_libs/releases)
- [Changelog](https://github.com/google/desugar_jdk_libs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/desugar_jdk_libs/commits)

---
updated-dependencies:
- dependency-name: com.android.tools:desugar_jdk_libs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch from e2f8fdc to 510f7ed Compare January 28, 2023 13:51
@AndyScherzinger
Copy link
Copy Markdown
Member

AndyScherzinger commented Jan 28, 2023

I would also expect that by now we can just go for Java11, so this shouldn't be needed anymore, no?

tobiasKaminsky
tobiasKaminsky requested changes Jan 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@tobiasKaminsky tobiasKaminsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this is not used at all.
When I remove it, I can still build it.

@AlvaroBrey
Copy link
Copy Markdown
Member

AlvaroBrey commented Jan 30, 2023 •
edited
Loading

I'll take a look later today, but for reference: https://developer.android.com/studio/write/java8-support#library-desugaring

tl;dr: This lib allows usage of java 8 features in SDK < 26. I've already seen some modern Java (like var ) in some Java files here.

@tobiasKaminsky
Copy link
Copy Markdown
Member

tobiasKaminsky commented Jan 30, 2023

Right…testing it on Android 11 is not the right test.
It crashes w/o with 6.0.
So we need it.

@AndyScherzinger AndyScherzinger merged commit 5c2816b into main Jan 30, 2023
@AndyScherzinger AndyScherzinger deleted the dependabot/gradle/com.android.tools-desugar_jdk_libs-2.0.0 branch January 30, 2023 15:46
@AndyScherzinger AndyScherzinger added this to the 3.8.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tobiasKaminsky @AlvaroBrey @AndyScherzinger