fix: Bust full preview cache by etag - #3695
Open
hweihwang wants to merge 1 commit into
Open
Conversation
Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Author
|
Hi @susnux, CI is green now. Could you take another look when you have a chance? Thanks! |
susnux
reviewed
Aug 3, 2026
| @@ -139,6 +139,8 @@ export function toViewerFileInfo(file: Node): ViewerFileInfo { | |||
| source = getRemoteURL() + getRootPath() + filename | |||
| } | |||
|
|
|||
| const decodedEtag = String(file.attributes.etag).replace(/"/g, '') | |||
Collaborator
There was a problem hiding this comment.
Is it really XML encoded?
Maybe make it a bit more resiliant:
Suggested change
| const decodedEtag = String(file.attributes.etag).replace(/"/g, '') | |
| const decodedEtag = String(file.attributes.etag).replace(/("|")/g, '') |
susnux
reviewed
Aug 3, 2026
| @@ -181,9 +181,11 @@ export default { | |||
| ) | |||
|
|
|||
| files.forEach((file) => { | |||
| const decodedEtag = String(file.attributes.etag).replace(/"/g, '') | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: overwriting an image updates the grid thumbnail, but Viewer can retain the old full preview because its cacheable URL lacks the etag.
Change: add the sanitized WebDAV etag to authenticated and public-album full-preview URLs.
Generated assets: rebuilt with the production build.
Test: added a Vitest regression for the authenticated preview URL; production build and targeted ESLint passed.
History: this supersedes closed PR #3546.