Skip to content

Conversation

@dartcafe
Copy link
Collaborator

No description provided.

@dartcafe dartcafe added this to the 0.8.0 milestone Oct 25, 2017
@dartcafe dartcafe requested a review from v1r0x October 25, 2017 15:19
@dartcafe dartcafe mentioned this pull request Oct 25, 2017
@dartcafe dartcafe changed the title removed NC specific items Changed screenshots to neutral Oct 25, 2017
@splitt3r
Copy link
Contributor

splitt3r commented Nov 1, 2017

What do you think about the solution in #224? I think it´s enough to only adapt the header from the screenshot to oC style and the build script will update the info.xml file.

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 2, 2017

The oc header with nc button style looks a bit weird. But 👍 for the makefile.
@dartcafe Maybe a script to export polls tables from the nc instance and import them to the oc instance could help reduce the amount of work? If you tell me what db type (psql, mysql, sqlite) and OS you use, I could give it a try.

@dartcafe
Copy link
Collaborator Author

dartcafe commented Nov 2, 2017

@v1r0x I already have a set on db entries for import in my nc and oc instances. I just have to make a cron for it to import users and polls over night.

@splitt3r are the db imports useful for the unit tests?

@splitt3r
Copy link
Contributor

splitt3r commented Nov 2, 2017

Nope don´t think so. The unit tests create / update / delete the data. So no need for some import.

@jancborchardt
Copy link
Member

jancborchardt commented Nov 6, 2017

I’m obviously a bit biased but from a presentation perspective it looks weird without context. How about just making the icon generic, like the example theme logo? https://github.com/nextcloud/server/blob/master/themes/example/core/img/logo-icon.svg

(Also, you are volunteers, so I honestly find it ridiculous that it is required by the people in question that you need to modify an app you provide to them to please their guidelines …)

@dartcafe
Copy link
Collaborator Author

dartcafe commented Nov 6, 2017

Hey @jancborchardt I'll try it. Good suggestion.

@splitt3r splitt3r changed the base branch from master to develop November 7, 2017 14:41
@splitt3r
Copy link
Contributor

splitt3r commented Nov 7, 2017

Changed the base branch to develop where i merged in my unit tests + the new makefile. Are you happy with the https://github.com/nextcloud/polls/blob/develop/Makefile#L133 + https://github.com/nextcloud/polls/tree/develop/screenshots solution? Otherwise delete my changes and merge 😛

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 7, 2017

Best solution (from a users perspective) would be real NC screenshots and real OC screenshots.
The best solution (from a devs perspective) would be the solution @jancborchardt suggested.

As long as we have no OC contributor or someone willing to setup a OC instance and take the screenshots twice, I'd go with @jancborchardt solution.

@dartcafe Would be awesome if you could add a neutral icon. Then we can merge this into the dev branch and revert the makefile "hack". Everybody ok with that? @dartcafe @splitt3r

@splitt3r
Copy link
Contributor

splitt3r commented Nov 7, 2017

Sounds good to me. But for example the menu also indicates Nc 😁

@v1r0x
Copy link
Collaborator

v1r0x commented Nov 7, 2017

I hope they don't care about the menu 😁

@splitt3r
Copy link
Contributor

splitt3r commented Nov 7, 2017

It's a themed oC enterprise edition xD

@joergmschulz
Copy link
Contributor

and a bit of NC propaganda isn't bad either ;-)

@dartcafe
Copy link
Collaborator Author

dartcafe commented Nov 7, 2017

We could make OC screenshots as default and publish them in the NC app store.

@dartcafe
Copy link
Collaborator Author

dartcafe commented Nov 7, 2017

Ha. No. We shouldn't be part of the emotions between NC and OC. In the end I will make screenshots from imported default polls. That works, just the users are a little bit tricky, because they have different user tables.

@splitt3r splitt3r modified the milestones: 0.8.0, 0.8.1 Nov 24, 2017
@dartcafe
Copy link
Collaborator Author

dartcafe commented Dec 1, 2017

Until further changes, I will make individual screenshots. I set up instances for NC and OC and pull the develop branch and reset the database nightly.

So I close this PR.

@dartcafe dartcafe closed this Dec 1, 2017
@dartcafe dartcafe deleted the neutral-screenshots branch December 1, 2017 18:35
@dartcafe
Copy link
Collaborator Author

dartcafe commented Dec 1, 2017

#256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants