-
Notifications
You must be signed in to change notification settings - Fork 83
Changed screenshots to neutral #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What do you think about the solution in #224? I think it´s enough to only adapt the header from the screenshot to oC style and the build script will update the info.xml file. |
|
The oc header with nc button style looks a bit weird. But 👍 for the makefile. |
|
Nope don´t think so. The unit tests create / update / delete the data. So no need for some import. |
|
I’m obviously a bit biased but from a presentation perspective it looks weird without context. How about just making the icon generic, like the example theme logo? https://github.com/nextcloud/server/blob/master/themes/example/core/img/logo-icon.svg (Also, you are volunteers, so I honestly find it ridiculous that it is required by the people in question that you need to modify an app you provide to them to please their guidelines …) |
|
Hey @jancborchardt I'll try it. Good suggestion. |
|
Changed the base branch to develop where i merged in my unit tests + the new makefile. Are you happy with the https://github.com/nextcloud/polls/blob/develop/Makefile#L133 + https://github.com/nextcloud/polls/tree/develop/screenshots solution? Otherwise delete my changes and merge 😛 |
|
Best solution (from a users perspective) would be real NC screenshots and real OC screenshots. As long as we have no OC contributor or someone willing to setup a OC instance and take the screenshots twice, I'd go with @jancborchardt solution. @dartcafe Would be awesome if you could add a neutral icon. Then we can merge this into the dev branch and revert the makefile "hack". Everybody ok with that? @dartcafe @splitt3r |
|
Sounds good to me. But for example the menu also indicates Nc 😁 |
|
I hope they don't care about the menu 😁 |
|
It's a themed oC enterprise edition xD |
|
and a bit of NC propaganda isn't bad either ;-) |
|
We could make OC screenshots as default and publish them in the NC app store. |
|
Ha. No. We shouldn't be part of the emotions between NC and OC. In the end I will make screenshots from imported default polls. That works, just the users are a little bit tricky, because they have different user tables. |
|
Until further changes, I will make individual screenshots. I set up instances for NC and OC and pull the develop branch and reset the database nightly. So I close this PR. |
No description provided.