fix(ci): unblock CI — enforce PHP 8.3 in psalm.xml + sync PHP workflow templates#1381
Merged
Conversation
CI step "Check enforcement of minimum PHP version 8.3 in psalm.xml" greps for phpVersion="8.3" in psalm.xml and fails when absent. NC35 (info.xml min-version) requires PHP 8.3+, so align psalm config. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Bumps shivammathur/setup-php 2.37.0 -> 2.37.2 and actions/checkout v6 -> v7 across all PHP workflows, plus fail-fast: false for phpunit. setup-php 2.37.0 provisions a composer version that resolves GitHub dist archives via the deprecated codeload legacy.zip endpoint, which now returns HTTP 400 and breaks 'composer install' in every PHP job (psalm, php-cs, phpunit). 2.37.2 fixes the download path. Re-running does not help since the broken action is pinned. Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two independent CI breakages on this branch, both fixed here:
psalm.xml— bump enforcedphpVersion8.2→8.3.nextcloud/.githubtemplates:shivammathur/setup-php2.37.0→2.37.2,actions/checkoutv6 → v7,fail-fast: falsefor phpunit matrices.Why
Static analysis
The
Static analysisjob runs a guardgrep 'phpVersion="8.3' psalm.xml(min PHP derived frominfo.xml, NC35 ⇒ 8.3).psalm.xmlwas pinned to8.2, so grep matched nothing and the step failed.All PHP jobs (psalm, php-cs, phpunit) —
composer installfailuresEvery PHP job failed at
Install dependencieswith:setup-php
2.37.0provisions a composer that resolves GitHub dist archives via the deprecatedcodeload.github.com/.../legacy.zipendpoint, which now returns HTTP 400. This is not transient — re-running keeps failing because the broken action version is pinned. Upstreamnextcloud/.githubalready bumped to2.37.2; this PR syncs the templates.Testing
AI disclosure
Assisted by Claude Code (claude-opus-4-8).