Increase theming performance #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Set proper caching headers (`Pragma: cache`) 2. Resize image proportionally to a max size of 1920px 3. Store images with progressive mode This resizes a previous 2.8 MB picture to 300kb and makes it rendering going down from 11 seconds to less than 1 here. And future requests won't have to download the file newly.
|
@LukasReschke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle, @juliushaertl and @nickvergessen to be potential reviewers |
Member
Author
Let's see why this PHP version behaves differently sigh |
LukasReschke
added
2. developing
LukasReschke
added
3. to review
Member
Author
|
Also @jancborchardt, since he complained about the performance ;) |
Member
|
👍 |
Member
|
Wow – very significant improvement. Very cool 👍 :) Yay for performance 🚀 |
This was referenced Aug 28, 2016
Member
|
@LukasReschke Awesome improvement. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pragma: cache)This resizes a previous 2.8 MB picture to 300kb and makes it rendering going down from 11 seconds to less than 1 here. And future requests won't have to download the file newly.
As a comparison these two GIFs show the rendering before and after the PR on initial page load:
(force reload the page to see it rendering)
Note that due the caching headers all future page loads will instantly show the right data. Something that is at the moment not properly done.
@ChristophWurst This should make you happier 😉
Fixes #1099