Skip to content

fix(snowflakes): create file lock files into lock directory #57921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Altahrim merged 2 commits into from
Feb 4, 2026
Merged

fix(snowflakes): create file lock files into lock directory #57921

Altahrim merged 2 commits into from
Feb 4, 2026
+4 −2

Conversation

@Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Jan 30, 2026

Summary

File locks are created outside of locks directory because of a missing /

Example: sfi_file_sequenceseq-009.lock instead of sfi_file_sequences/eq-009.lock

Checklist

@Altahrim Altahrim added this to the Nextcloud 34 milestone Jan 30, 2026
@Altahrim Altahrim self-assigned this Jan 30, 2026
@Altahrim Altahrim requested a review from a team as a code owner January 30, 2026 10:08
@Altahrim Altahrim added bug 3. to review Waiting for reviews labels Jan 30, 2026
@Altahrim Altahrim requested review from icewind1991, leftybournes, nfebe and salmart-dev and removed request for a team January 30, 2026 10:08
@Altahrim
Copy link
Collaborator Author

Altahrim commented Jan 30, 2026

/backport to stable33

@Altahrim Altahrim added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 2, 2026
@Altahrim Altahrim marked this pull request as draft February 2, 2026 08:10
@Altahrim Altahrim force-pushed the fix/snowflake_lock_dir branch 2 times, most recently from 9c2ef72 to 4c37980 Compare February 2, 2026 10:03
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 2, 2026
@Altahrim Altahrim marked this pull request as ready for review February 2, 2026 10:19
@Altahrim
Copy link
Collaborator Author

Altahrim commented Feb 2, 2026

Unrelated CI failures

come-nc
come-nc reviewed Feb 3, 2026
View reviewed changes
@Altahrim
fix(snowflakes): create file lock files into lock directory
65c9e34 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
chore(snowflakes): don't remove file lock directory during tests
e15b429 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim force-pushed the fix/snowflake_lock_dir branch from 4c37980 to e15b429 Compare February 3, 2026 16:01
@Altahrim Altahrim merged commit 687261f into master Feb 4, 2026
200 of 213 checks passed
@Altahrim Altahrim deleted the fix/snowflake_lock_dir branch February 4, 2026 10:12
@backportbot backportbot bot mentioned this pull request Feb 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@come-nc come-nc come-nc left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@provokateurin provokateurin provokateurin approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

4 participants

@Altahrim @CarlSchwan @provokateurin @come-nc