fix(comments): register event listener for typed comment events#59909
Merged
nickvergessen merged 1 commit intomasterfrom May 4, 2026
Merged
fix(comments): register event listener for typed comment events#59909nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
miaulalala
added
3. to review
miaulalala
requested review from
ArtificialOwl,
come-nc and
provokateurin
and removed request for
a team
Since the typed comment events (CommentAddedEvent, CommentUpdatedEvent, etc.) were introduced in NC34, dispatchTyped() dispatches using the exact subclass name. Registering only for CommentsEvent::class means the listener never fires, so comment mention notifications are never created or cleared. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
fix/comments-event-listener-registration
branch
from
8431485 to
9700875
Compare
Contributor
Author
|
/backport to stable33 |
Member
|
Creating bell notifications works, clearance seems to not work, neither in the notification list nor the bubble in the file list |
come-nc
reviewed
May 4, 2026
CarlSchwan
approved these changes
May 4, 2026
Member
|
And a followup #60137 |
Contributor
Author
that is fixed in the follow up PR #59918 |
nickvergessen
approved these changes
May 4, 2026
Member
It used to work as there was a link to go to the comment from the full subject, but since the subject contains mention chip and a file link by now, the subject is no longer linked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the typed comment events (CommentAddedEvent, CommentUpdatedEvent, etc.) were introduced in NC34, dispatchTyped() dispatches using the exact subclass name. Registering only for CommentsEvent::class means the listener never fires, so comment mention notifications are never created or cleared.
Change introduced in #56076
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com
Checklist
3. to review, feature component)stable32)AI (if applicable)