[stable33] fix(comments): register event listener for typed comment events#60149
Merged
miaulalala merged 1 commit intostable33from May 5, 2026
Merged
[stable33] fix(comments): register event listener for typed comment events#60149miaulalala merged 1 commit intostable33from
miaulalala merged 1 commit intostable33from
Conversation
backportbot
Bot
added
bug
3. to review
backportbot
Bot
requested review from
Altahrim,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
nickvergessen
approved these changes
May 4, 2026
miaulalala
approved these changes
May 5, 2026
Since the typed comment events (CommentAddedEvent, CommentUpdatedEvent, etc.) were introduced in NC34, dispatchTyped() dispatches using the exact subclass name. Registering only for CommentsEvent::class means the listener never fires, so comment mention notifications are never created or cleared. AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
backport/59909/stable33
branch
from
d4a3e59 to
3bef50d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #59909