fix(unified-search): catch errors in response - #61437
Closed
leftybournes wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Kent Delante <kent@delante.me> When an error response is returned by the unified search api, unified search shows an endless "Searching" message. This catches the error and sets the modal into a non-searching state so it no longer endlessly shows the message.
leftybournes
requested review from
nfebe,
sorbaugh and
susnux
and removed request for
a team
June 19, 2026 09:25
Member
Author
|
Issue has been fixed on master (but not on previous versions) |
leftybournes
deleted the
leftybournes/fix/unified-search-fix-endless-searching
branch
July 28, 2026 10:53
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an error response is returned by the unified search api, unified search shows an endless "Searching" message. This catches the error and sets the modal into a non-searching state so it no longer endlessly shows the message.
Checklist
3. to review, feature component)stable32)AI (if applicable)