fix(core): handle parameter limits in files metadata deletion#62331
Open
gitedmond wants to merge 1 commit into
Open
fix(core): handle parameter limits in files metadata deletion#62331gitedmond wants to merge 1 commit into
gitedmond wants to merge 1 commit into
Conversation
Refactor dropMetadataForFiles and dropIndexForFiles to chunk by 500 and wrap in database transactions to avoid query parameter limit errors on Oracle and PostgreSQL. Assisted-by: Antigravity:Gemini-3.5-Flash Signed-off-by: Edmond <edmnd@users.noreply.github.com>
gitedmond
force-pushed
the
fix/db-parameter-limits
branch
from
July 19, 2026 18:38
a56d71c to
48551eb
Compare
gitedmond
marked this pull request as ready for review
July 19, 2026 18:42
gitedmond
requested review from
come-nc,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
July 19, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor dropMetadataForFiles and dropIndexForFiles to chunk by 500 and wrap in database transactions to avoid query parameter limit errors on Oracle and PostgreSQL.
Assisted-by: Antigravity:Gemini-3.5-Flash
Summary
Refactor
dropMetadataForFilesanddropIndexForFilesto chunk by 500 and wrap in database transactions to avoid query parameter limit errors on Oracle and PostgreSQL.It looks like there was already some chunking logic set up here, but it was accidentally passing the original huge file id array instead of the chunked one. This pr just swaps that variable out so chunking actually works and wraps the loop in a transaction to keep the db happy.
Changes
$chunkvariable instead of the original$fileIdsarray.500to prevent queries from exceeding database parameter limits.beginTransaction/commit/rollBack) to optimize performance and prevent inconsistency on failure.tests/lib/FilesMetadata/FilesMetadataManagerTest.php.Checklist
git commit --amend -son the branch to add your DCO signature)3. to review, feature component)stable32)AI (if applicable)