Skip to content

fix(NavigationManager): do not warn when an unknown entry is requested #62361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
solracsf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(NavigationManager): do not warn when an unknown entry is requested #62361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/private/NavigationManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ public function setUnreadCounter(string $id, int $unreadCounter): void {
#[Override]
public function get(string $id): ?array {
$this->resolveAppNavigationEntries();
return $this->entries[$id];
return $this->entries[$id] ?? null;
}

#[Override]
Expand Down
7 changes: 7 additions & 0 deletions tests/lib/NavigationManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ public function testAddClosure(array $entry, array $expectedEntry): void {
$this->assertEmpty($this->navigationManager->getAll('all'), 'Expected no navigation entry exists after clear()');
}

public function testGetUnknownEntryReturnsNull(): void {
// Requesting an entry no app has registered must return null without
// emitting an "Undefined array key" warning, e.g. when an app without
// a navigation entry renders a public page
$this->assertNull($this->navigationManager->get('unknown'));
}

public function testAddArrayClearGetAll(): void {
$entry = [
'id' => 'entry id',
Expand Down
Loading