Skip to content

chore(previews): add file signature check before opening files - #62600

Merged
Altahrim merged 2 commits into
masterfrom
imagemafix
Jul 28, 2026
Merged

chore(previews): add file signature check before opening files#62600
Altahrim merged 2 commits into
masterfrom
imagemafix

Conversation

@Altahrim

@Altahrim Altahrim commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Re-enable Imagick

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@Altahrim Altahrim added this to the Nextcloud 35 milestone Jul 28, 2026
@Altahrim Altahrim self-assigned this Jul 28, 2026
@Altahrim Altahrim added the 2. developing Work in progress label Jul 28, 2026
Altahrim added 2 commits July 28, 2026 10:44
@Altahrim
feat(previews): add file signature check before opening files
e8d545e 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Revert "fix: Disable imagick preview providers"
26f69a8 
This reverts commit 706fe8f.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim added 3. to review Waiting for reviews feature: previews and thumbnails php Pull requests that update Php code and removed 2. developing Work in progress labels Jul 28, 2026
@Altahrim
Altahrim marked this pull request as ready for review July 28, 2026 09:25
@Altahrim
Altahrim requested a review from a team as a code owner July 28, 2026 09:25
@Altahrim
Altahrim requested review from come-nc, icewind1991, leftybournes and salmart-dev and removed request for a team July 28, 2026 09:25
@Altahrim

Altahrim commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable34

@Altahrim

Altahrim commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable33

@Altahrim

Altahrim commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable32

@Altahrim

Altahrim commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable31

@Altahrim
Altahrim merged commit 3db869a into master Jul 28, 2026
247 of 267 checks passed
@Altahrim
Altahrim deleted the imagemafix branch July 28, 2026 13:57
This was referenced Jul 28, 2026
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes
@provokateurin provokateurin provokateurin approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels

3. to review Waiting for reviews feature: previews and thumbnails php Pull requests that update Php code

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot generate previews for heic files since upgrade to 34.0.2

3 participants

@Altahrim @artonge @provokateurin