Skip to content

fix: clear key password after loading key - #62806

Merged
susnux merged 2 commits into
masterfrom
sftp-key-remove-password
Aug 3, 2026
Merged

fix: clear key password after loading key#62806
susnux merged 2 commits into
masterfrom
sftp-key-remove-password

Conversation

@icewind1991

@icewind1991 icewind1991 commented Aug 3, 2026

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Ensure it can't be leaked later on

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@icewind1991 icewind1991 added this to the Nextcloud 35 milestone Aug 3, 2026
@icewind1991
icewind1991 requested a review from a team as a code owner August 3, 2026 20:45
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 3, 2026
@icewind1991
icewind1991 requested review from Altahrim, nfebe, salmart-dev and sorbaugh and removed request for a team August 3, 2026 20:45
@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable34

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable33

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable32

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable31

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable30

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable29

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable28

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable27

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable26

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable25

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable24

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable23

@icewind1991

Copy link
Copy Markdown
Member Author

/backport to stable22

@icewind1991
icewind1991 force-pushed the sftp-key-remove-password branch from e5e4cb1 to 55b9808 Compare August 3, 2026 21:03
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>

# Conflicts:
#	apps/files_external/lib/Lib/Auth/PublicKey/RSA.php

# Conflicts:
#	apps/files_external/lib/Lib/Auth/PublicKey/RSA.php
#	apps/files_external/lib/Lib/Auth/PublicKey/RSAPrivateKey.php
@icewind1991
icewind1991 force-pushed the sftp-key-remove-password branch from 55b9808 to f6b6541 Compare August 3, 2026 21:29
@susnux
susnux merged commit a2e9eff into master Aug 3, 2026
217 of 220 checks passed
@susnux
susnux deleted the sftp-key-remove-password branch August 3, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants