fix(share): Prevent type error caused by non-existing user - #62872
Merged
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
come-nc,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
August 4, 2026 09:45
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
susnux
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the auto_groups app, it is currently adding user back to the Everyone group when trying to delete the user, which then tries to accept the group share again with an user that doesn't exist.
Here is a proper fix for the auto_groups app: jo23sh/auto_groups#94 but it doesn't hurt to also harden server.
Checklist
3. to review, feature component)stable32)AI (if applicable)