Skip to content

style(icons): use filled variants for user, comment, share, password - #62947

Merged
susnux merged 2 commits into
masterfrom
fix/noid/filled-core-action-icons
Aug 6, 2026
Merged

style(icons): use filled variants for user, comment, share, password#62947
susnux merged 2 commits into
masterfrom
fix/noid/filled-core-action-icons

Conversation

@pringelmann

Copy link
Copy Markdown
Contributor

Summary

Activity's navigation mixed filled and outline icons. The outline ones are shared core assets, so this swaps four of them for the filled Material Symbols variants. The .png siblings go along since they're used for activity emails.

These assets also show up in notifications and settings sections, so it changes them there too.

Before After
image image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@pringelmann pringelmann added this to the Nextcloud 35 milestone Aug 5, 2026
@pringelmann pringelmann self-assigned this Aug 5, 2026
@pringelmann
pringelmann requested a review from a team as a code owner August 5, 2026 15:02
@pringelmann
pringelmann requested review from Altahrim and removed request for a team August 5, 2026 15:02
@pringelmann pringelmann added the design Design, UI, UX, etc. label Aug 5, 2026
@pringelmann pringelmann added the 3. to review Waiting for reviews label Aug 5, 2026
@pringelmann
pringelmann requested a review from artonge August 5, 2026 15:02
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann force-pushed the fix/noid/filled-core-action-icons branch from 04efc09 to 438a714 Compare August 5, 2026 16:21
@pringelmann
pringelmann requested a review from kra-mo August 5, 2026 16:41
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann requested a review from a team as a code owner August 6, 2026 06:34
@pringelmann
pringelmann requested review from kristian-zendato, skjnldsv and sorbaugh and removed request for a team August 6, 2026 06:34
@susnux
susnux merged commit e9b5cf8 into master Aug 6, 2026
132 checks passed
@susnux
susnux deleted the fix/noid/filled-core-action-icons branch August 6, 2026 11:47
@github-project-automation github-project-automation Bot moved this to 🎉 Done in 🖍 Design team Aug 6, 2026
@jancborchardt

jancborchardt commented Aug 6, 2026

Copy link
Copy Markdown
Member

We should use outlined icons here everywhere in the nav, except for the active entry which should be filled.

Yes indeed, really sorry for the lack of detail on the issue

@pringelmann

Copy link
Copy Markdown
Contributor Author

Actually the original issue seems wrong? nextcloud/activity#2662 FYI @artonge

We should use outlined icons here everywhere in the nav, except for the active entry which should be filled. Sorry for the confusion @pringelmann

Ah I see, no worries will fix

@pringelmann

pringelmann commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@jancborchardt one trade-off worth flagging: in order to switch out active & inactive icon states we will have to create and maintain an icon map. This will only reference core filters/apps. We could extend it to include specific 3rd party apps, but there is a risk that they become stale if the app ever changes its icon.

Another issue is that some app icons like Deck don't have MDI equivalents, so we'd have to either ship the app icon with activity, or use a different icon.

Without 3rd-party mapping With 3rd-party mapping: (custom Deck icon)
image image

pringelmann added a commit that referenced this pull request Aug 7, 2026
…-action-icons"

This reverts commit e9b5cf8, reversing
changes made to 9ee4fa8.

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

Use filled icons in the part of Activity

4 participants