feat: add shared resource section to profile - #63002
Conversation
cc0308a to
c89531f
Compare
0bded87 to
235053f
Compare
|
@kristian-zendato please attach some screenshots so I have a reference (and add me as a reviewer in the future). |
235053f to
fdd5165
Compare
kra-mo
left a comment
There was a problem hiding this comment.
The screenshots you provided seem to lack the changes from #62646. How would alignment look with those present as well?
I'm just thinking that the shared resources section should be as wide as the primary button (e.g. Open Talk).
The rest looks good :)
fdd5165 to
f235c4e
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Very nice! Only one thing: Shares seem sorted by oldest first? Should be most recent first though.
Claude Opus 5 review mentioned this, but the links seem to be fine and clickable on both ends:
One bug seen in API output: file links point to the owner's path, not the viewer's.
href = .../apps/files/?dir=/user1/files&fileid=1454 from apps/profile/lib/Controller/ProfileApiController.php:174 using $node->getParent()->getPath(). For an incoming share the viewer has no /user1/files dir. Simpler and correct: link by file id only (files.View.showFile, i.e. /f/{fileid}).
f235c4e to
09b28e7
Compare
jancborchardt
left a comment
There was a problem hiding this comment.
Nice, looks good now! :)
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
09b28e7 to
23e8d04
Compare
Summary
Adds a You & {user} shared resources section on other users' profile so viewers can quickly see what they have in common
GET /apps/profile/api/v1/resources/{userId}returns shared file/folder and upcoming calendar events between the current user and the profile ownerSharedResourcesSectionScreenshots
With shared resources(Files and Events)
Mobile
Checklist
3. to review, feature component)stable32)AI (if applicable)