Skip to content

feat: add shared resource section to profile - #63002

Merged
susnux merged 3 commits into
masterfrom
feat/profile-shared-resource
Aug 13, 2026
Merged

feat: add shared resource section to profile#63002
susnux merged 3 commits into
masterfrom
feat/profile-shared-resource

Conversation

@kristian-zendato

@kristian-zendato kristian-zendato commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a You & {user} shared resources section on other users' profile so viewers can quickly see what they have in common

  • New OCS endpoint GET /apps/profile/api/v1/resources/{userId} returns shared file/folder and upcoming calendar events between the current user and the profile owner
  • Shared files show previews(or a folder icon), relative timestaps, and links into Files
  • Shared calendar events(when Calendar is enabled) link in to the Calendar app
  • Frontend loads resources only when viewing another user's profile and renders SharedResourcesSection

Screenshots

With shared resources(Files and Events)

image

Mobile

image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kristian-zendato
kristian-zendato requested review from a team and provokateurin as code owners August 7, 2026 06:46
@kristian-zendato
kristian-zendato requested review from Altahrim, nfebe, salmart-dev, skjnldsv and sorbaugh and removed request for a team August 7, 2026 06:46
@kristian-zendato
kristian-zendato force-pushed the feat/profile-shared-resource branch 2 times, most recently from cc0308a to c89531f Compare August 7, 2026 07:42
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Aug 7, 2026
@kristian-zendato
kristian-zendato force-pushed the feat/profile-shared-resource branch 2 times, most recently from 0bded87 to 235053f Compare August 7, 2026 08:08
@kra-mo

kra-mo commented Aug 11, 2026

Copy link
Copy Markdown
Member

@kristian-zendato please attach some screenshots so I have a reference (and add me as a reviewer in the future).

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Aug 11, 2026
@kristian-zendato
kristian-zendato force-pushed the feat/profile-shared-resource branch from 235053f to fdd5165 Compare August 11, 2026 09:36
kra-mo
kra-mo previously requested changes Aug 11, 2026

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots you provided seem to lack the changes from #62646. How would alignment look with those present as well?

I'm just thinking that the shared resources section should be as wide as the primary button (e.g. Open Talk).

The rest looks good :)

Comment thread apps/profile/src/components/SharedResourcesSection.vue Outdated
Comment thread apps/profile/lib/Controller/ProfileApiController.php Outdated
@kristian-zendato
kristian-zendato force-pushed the feat/profile-shared-resource branch from fdd5165 to f235c4e Compare August 11, 2026 10:54

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only one thing: Shares seem sorted by oldest first? Should be most recent first though.

Claude Opus 5 review mentioned this, but the links seem to be fine and clickable on both ends:

One bug seen in API output: file links point to the owner's path, not the viewer's.
href = .../apps/files/?dir=/user1/files&fileid=1454 from apps/profile/lib/Controller/ProfileApiController.php:174 using $node->getParent()->getPath(). For an incoming share the viewer has no /user1/files dir. Simpler and correct: link by file id only (files.View.showFile, i.e. /f/{fileid}).

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good now! :)

@jancborchardt jancborchardt added design Design, UI, UX, etc. feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) enhancement labels Aug 12, 2026
susnux and others added 3 commits August 13, 2026 14:28
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: kristian-zendato <kristian.zendato@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux force-pushed the feat/profile-shared-resource branch from 09b28e7 to 23e8d04 Compare August 13, 2026 12:29
@susnux
susnux merged commit 51c1a32 into master Aug 13, 2026
199 checks passed
@susnux
susnux deleted the feat/profile-shared-resource branch August 13, 2026 13:22
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Aug 13, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

User Profile - 4 - New Sections

5 participants