fix(CalDAV): Check for user status before serving public calendars - #63004
Conversation
|
/backport to stable34 |
|
/backport to stable33 |
|
/backport to stable32 |
07259e9 to
40c4657
Compare
40c4657 to
7e53c36
Compare
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
7e53c36 to
f1838ab
Compare
| return true; | ||
| } | ||
|
|
||
| return $this->userManager->get((string)$name)?->isEnabled() !== false; |
There was a problem hiding this comment.
null !== false ;)
Unlikely state I know, but found it still weird while reading the code.
There was a problem hiding this comment.
This should at least throw so that we know about this happening instead of silently succeed.
Or handle null just like false and do
| return $this->userManager->get((string)$name)?->isEnabled() !== false; | |
| return $this->userManager->get((string)$name)?->isEnabled() === true; |
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/63004/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f1838ab8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63004/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/63004/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f1838ab8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63004/stable33Error: Failed to check for changes with origin/stable33: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable34
git pull origin stable34
# Create the new backport branch
git checkout -b backport/63004/stable34
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick f1838ab8
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/63004/stable34Error: Failed to check for changes with origin/stable34: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
Manual backports opened - please review |
Summary
This PR adds support for the
hide_disabled_user_sharessetting on calendars.Checklist
3. to review, feature component)stable32)AI (if applicable)