fix: Refresh all conversations when deleted from one not active in#18129
Merged
Antreesy merged 1 commit intoMay 28, 2026
Merged
Conversation
When the HPB is used and a user is removed from a conversation that user receives a "disinvite" signaling message. This triggered a "should-refresh-conversations" event, but (unless it coincides with the periodical forced refresh) only those conversations modified since the last fetch will be got. As the deleted conversation is no longer accessible by the user it will not be returned in the "modified since" response, and the conversation list will not be properly updated. Due to that a "disinvite" message for a conversation that the user is not active in should trigger a forced refresh of all the conversations instead of a normal refresh. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
feature: signaling 📶
Member
Author
|
/backport to stable34 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
Antreesy
approved these changes
May 28, 2026
Antreesy
deleted the
refresh-all-conversations-when-deleted-from-one-not-active-in
branch
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a regression probably introduced in #8726 (so, by now, it could be just called a bug :-P )
When the HPB is used and a user is removed from a conversation that user receives a
disinvitesignaling message. This triggered ashould-refresh-conversationsevent, but (unless it coincides with the periodical forced refresh) only those conversations modified since the last fetch will be got. As the deleted conversation is no longer accessible by the user it will not be returned in the modified since response, and the conversation list will not be properly updated. Due to that adisinvitemessage for a conversation that the user is not active in should trigger a forced refresh of all the conversations instead of a normal refresh.Note that although found while reviewing #16759 it is unrelated, as
disinvitemessages will still be sent to users removed from a conversation.How to test
Result with this pull request
In the private window the conversation is removed from the left sidebar
Result without this pull request
In the private window the conversation is not removed from the left sidebar until a few minutes have passed (at most 5, when all the conversations are force refreshed)