Skip to content

feat(conversations): Allow to preserve conversations (restrict deletion, purging, public link and listable change) - #18351

Merged
nickvergessen merged 3 commits into
mainfrom
feat/noid/make-ownership-matter
Jun 24, 2026
Merged

feat(conversations): Allow to preserve conversations (restrict deletion, purging, public link and listable change)#18351
nickvergessen merged 3 commits into
mainfrom
feat/noid/make-ownership-matter

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Jun 16, 2026

Copy link
Copy Markdown
Member

☑️ Resolves

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

🖼️ Screenshots / Screencasts

Settings Confirmation
grafik Bildschirmfoto vom 2026-06-16 08-32-54 image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added this to the ⛅ Next Major (35) milestone Jun 16, 2026
@nickvergessen nickvergessen self-assigned this Jun 16, 2026
@nickvergessen nickvergessen added enhancement feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: conversations 👥 AI assisted This PR contains AI-assisted commits labels Jun 16, 2026
Comment thread src/components/ConversationSettings/ConversationSettingsDialog.vue Outdated
Comment on lines +104 to +106
isPreserved() {
return Boolean(this.conversation.attributes & CONVERSATION.ATTRIBUTE.PRESERVE)
},

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if there should be a global place to have this, since it's used in multiple components? But don't know frontend well enough.

@nickvergessen nickvergessen Jun 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondered for the backend as well, but would delay until we have more use cases and then add a hasAttribute function to the conversation?

Comment thread src/components/ConversationSettings/StopPreservingDialog.vue
Comment thread src/components/ConversationSettings/StopPreservingDialog.vue Outdated

@SystemKeeper SystemKeeper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

nickvergessen and others added 3 commits June 19, 2026 13:48
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the feat/noid/make-ownership-matter branch from 5414bf1 to 268a040 Compare June 19, 2026 16:45
@Antreesy

Copy link
Copy Markdown
Contributor

Refactored UI, rebased. Please double-check before merging

@nickvergessen

Copy link
Copy Markdown
Member Author

Still looks good and worked

@nickvergessen
nickvergessen merged commit 9c22274 into main Jun 24, 2026
79 checks passed
@nickvergessen
nickvergessen deleted the feat/noid/make-ownership-matter branch June 24, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted This PR contains AI-assisted commits enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: conversations 👥 feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict deleting of conversations to owners

3 participants