fix(sip): Handle direct incoming calls as phone participants

[nickvergessen]

☑️ Resolves

• Fix Dial-in room participant added as guest, not as a phone participant #18123

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not possible
• 📘 API documentation in docs/ has been updated or is not required
• 🔖 Capability is added or not needed

[nickvergessen]

/backport to stable34

[nickvergessen]

/backport to stable33

[nickvergessen]

/backport to stable32

[SystemKeeper]

This returns null in my case. In this method $caller is 4912345 instead of +4912345. If the + is added in front, it is correctly recognized. (or alternatively the default region is set, but it should also work without,

spreed/lib/Service/PhoneNumberValidation.php

Lines 42 to 43 in 8f9dd1d

	$defaultRegion = $this->config->getSystemValueString('default_phone_region') ?: null;
	$standardPhoneNumber = $this->phoneNumberUtil->convertToStandardFormat($phoneNumber, $defaultRegion);

)

Since the + is missing, we add the phone attendee as 4912345. That means when calling back we dial +494912345 (which is then - depending on the sip config - converted to 00494912345).

[SystemKeeper]

@fancycode I guess it is expected that the sipbridge calls the direct-call-in endpoint without the + in front of the number? Would it be safe to add it on our side to have a correct converting?

[nickvergessen]

We have a setting for the dial-out prefix:

Not sure if it makes sense to use that?

[fancycode]

@fancycode I guess it is expected that the sipbridge calls the direct-call-in endpoint without the + in front of the number?

Yes, the numbers received by the SIP bridge in (To / From) might be an extension only in case of a on-premise PBX and internal calls, so it can't just prefix it with +.

Would it be safe to add it on our side to have a correct converting?

Similar to the SIP bridge you also can't add the + unconditionally.