📣 API: Add announcement and channel preset#18685
Open
nickvergessen wants to merge 15 commits into
Open
Conversation
…tions Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
…d live translations Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
… classified conversations Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
…rticipants Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
… preset Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
…fications Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
…l preset Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
enhancement
feature: api 🛠️
nickvergessen
force-pushed
the
feat/18679/classified-conversation-preset
branch
from
July 16, 2026 14:22
300c768 to
9254536
Compare
| 'token' => '[a-z0-9]{4,30}', | ||
| ])] | ||
| public function setSIPEnabled(int $state): DataResponse { | ||
| if ($this->room->isClassified() && $state !== Webinary::SIP_DISABLED) { |
Contributor
There was a problem hiding this comment.
Why do we allow setting it to disable?
Contributor
There was a problem hiding this comment.
I guess we could just directly set it? Or is there something else that could be used ?
Contributor
There was a problem hiding this comment.
Similarly, is there a reason for NONE check?
nickvergessen
force-pushed
the
feat/18679/classified-conversation-preset
branch
from
July 17, 2026 12:04
9254536 to
3fa8b1b
Compare
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required