Silent call default - #18909
Conversation
Antreesy
left a comment
There was a problem hiding this comment.
Thanks for the contribution, left some notes.
What's the reasoning behind the PR? I'm struggling to imagine the case, where all calls are expected to be silent; notifying others is an expected intention to engage them in joining the call
| silentCall: { | ||
| type: Boolean, | ||
| default: false, | ||
| default: null, |
There was a problem hiding this comment.
It's better be set directly in TopBar.vue, where it's visible; but design-wise it wouldn't be nice to hold a call button with such long text.
There was a problem hiding this comment.
in
spreed/src/components/TopBar/TopBar.vue
Line 130 in 48ca819
<CallButton v-if="!isInCall" :silentCall="directSilentCall" shrinkOnMobile />
and below in component:
directSilentCall() {
return !this.settingsStore.showMediaSettings // only when dialog is not shown
&& this.settingsStore.defaultCallMethodIsSilent // and your new setting is on
}There was a problem hiding this comment.
still not needed to change default to null, it's correctly resolved if not passed
… into silentCallDefault
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: Vater Solution GmbH - progge <progge@vater-gruppe.de>
… into silentCallDefault
|
Thank you for your quick review!
This setting lets users decide which option they want to default to and still be able to skip the device preview. |
Signed-off-by: Peter Rogge <progge@vater-gruppe.de>
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: Vater Solution GmbH - progge <progge@vater-gruppe.de>
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com> Signed-off-by: Vater Solution GmbH - progge <progge@vater-gruppe.de>
Signed-off-by: Peter Rogge <progge@vater-gruppe.de>
… into silentCallDefault
|
Thanks for the contribution again! So, we just discussed it internally, and decided that additional setting is not the best way to proceed UI/UX-wise. We'll try to go with the split button, like for ending call, to skip device check and start a silent call instead. That should serve your goal, without introducing an extra cognitive load, and make it closer to mobile clients. |
|
☑️ Resolves
Skipping the device preview also hid the checkbox for silent calls. There now is an option in the settings to default to silent calls. Also checks the checkbox when the device preview is not skipped.
AI (if applicable)
Copilot (Auto-Model) was used to help with analysis of the code structure and for suggestions as it has been a long time since I last used vue.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist
reviewed, approved orinspired by the design team