Skip to content

Silent call default - #18909

Closed
proggesol wants to merge 20 commits into
nextcloud:mainfrom
proggesol:silentCallDefault
Closed

Silent call default#18909
proggesol wants to merge 20 commits into
nextcloud:mainfrom
proggesol:silentCallDefault

Conversation

@proggesol

@proggesol proggesol commented Aug 4, 2026

Copy link
Copy Markdown

☑️ Resolves

Skipping the device preview also hid the checkbox for silent calls. There now is an option in the settings to default to silent calls. Also checks the checkbox when the device preview is not skipped.

AI (if applicable)

  • The content of this PR was partly or fully generated using AI
    Copilot (Auto-Model) was used to help with analysis of the code structure and for suggestions as it has been a long time since I last used vue.

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • Translate "Start calls silently by default"

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, left some notes.
What's the reasoning behind the PR? I'm struggling to imagine the case, where all calls are expected to be silent; notifying others is an expected intention to engage them in joining the call

Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
Comment thread src/components/MediaSettings/MediaSettings.vue Outdated
Comment thread src/components/SettingsDialog/SettingsDialog.vue Outdated
silentCall: {
type: Boolean,
default: false,
default: null,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better be set directly in TopBar.vue, where it's visible; but design-wise it wouldn't be nice to hold a call button with such long text.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your suggestion here?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in

<CallButton v-if="!isInCall" shrinkOnMobile />
add:

<CallButton v-if="!isInCall" :silentCall="directSilentCall" shrinkOnMobile />

and below in component:

directSilentCall() {
	return !this.settingsStore.showMediaSettings // only when dialog is not shown
		&& this.settingsStore.defaultCallMethodIsSilent  // and your new setting is on
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not needed to change default to null, it's correctly resolved if not passed

Comment thread src/stores/settings.ts Outdated
@proggesol

Copy link
Copy Markdown
Author

Thank you for your quick review!

What's the reasoning behind the PR? I'm struggling to imagine the case, where all calls are expected to be silent; notifying others is an expected intention to engage them in joining the call

  1. In our company we use chat groups not only for fixed team conversations, but also for appointment meeting rooms. Some participants are optional and do not want to be notified of calls every time.
  2. Also, when someone is a bit early for the meeting but wants to start the call let's say 5 minutes in advance(some people in our company do that all the time. If they don't, they often forget about the meeting at all), others should not be notified.
  3. Some people in certain teams open a virtual office every day. Everyone in the group chat can join, but not everyone wants to. They should not be notified.
  4. We are coming from MS Teams where this is the default behaviour. In our company silent calls are - as described above - wanted more often than notifying one.

This setting lets users decide which option they want to default to and still be able to skip the device preview.

@proggesol
proggesol requested a review from Antreesy August 4, 2026 11:07
Signed-off-by: Peter Rogge <progge@vater-gruppe.de>
Comment thread src/components/SettingsDialog/SettingsDialog.vue Outdated
Comment thread src/components/SettingsDialog/SettingsDialog.vue Outdated
proggesol and others added 4 commits August 4, 2026 13:45
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Vater Solution GmbH - progge <progge@vater-gruppe.de>
Co-authored-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Vater Solution GmbH - progge <progge@vater-gruppe.de>
Signed-off-by: Peter Rogge <progge@vater-gruppe.de>
@nickvergessen nickvergessen added this to the ⛅ Next Major (35) milestone Aug 5, 2026
@nickvergessen nickvergessen added enhancement feature: settings ⚙️ Settings and config related issues feature: frontend 🖌️ "Web UI" client feature: call 📹 Voice and video calls labels Aug 5, 2026
@proggesol
proggesol requested a review from Antreesy August 5, 2026 08:37
Comment thread l10n/de_DE.js
Antreesy

This comment was marked as outdated.

@Antreesy

Antreesy commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution again! So, we just discussed it internally, and decided that additional setting is not the best way to proceed UI/UX-wise.

We'll try to go with the split button, like for ending call, to skip device check and start a silent call instead. That should serve your goal, without introducing an extra cognitive load, and make it closer to mobile clients.

@nickvergessen

nickvergessen commented Aug 7, 2026

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client feature: settings ⚙️ Settings and config related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants