chore(config): refactor max-gif-size setting to valid ConfigLexicon name pattern with underscores max_gif_size - #19222
Merged
nickvergessen merged 2 commits intoSep 3, 2026
Conversation
…ame pattern with underscores Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
sudormant
added
feature: settings ⚙️
nickvergessen
requested changes
Sep 2, 2026
| new Entry(Config::CREATE_SAMPLES, ValueType::BOOL, true, definition: 'Create sample conversations (the content can be overwritten by providing files in a provided `samples_directory` app config)'), | ||
| new Entry(Config::MATTERBRIDGE_ENABLED, ValueType::BOOL, false, definition: 'Whether the Matterbridge integration is enabled and can be configured'), | ||
| new Entry(Config::DELETE_ONE_TO_ONE_CONVERSATIONS, ValueType::BOOL, false, definition: 'Whether one-to-one conversations can be left by either participant or should be deleted when one participant leaves'), | ||
| new Entry(Config::MAX_GIF_SIZE, ValueType::INT, 3145728, definition: 'Maximum file size for clients to render gifs previews with animation'), |
Member
There was a problem hiding this comment.
Should add 'max-gif-size' as rename option?
Signed-off-by: Christian Lorang <christian.lorang@nextcloud.com>
nickvergessen
approved these changes
Sep 2, 2026
nickvergessen
deleted the
refactor/config/RefactorTalkConfigToAppConfigMaxGifSize
branch
September 3, 2026 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏁 Checklist
docs/has been updated or is not requiredhelpful commands:
occ config:app:delete spreed max_gif_sizeocc config:app:set spreed max_gif_size --value 3145728 --type integer