Leave call and room when logging out - #1929
Merged
nickvergessen merged 1 commit intoJul 3, 2019
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
/backport to stable16 |
danxuliu
approved these changes
Jul 3, 2019
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
Tested (with and without MCU) and works 👍
delete-merged-branch
Bot
deleted the
bugfix/1872/leave-call-and-room-when-logging-out
branch
July 3, 2019 09:07
|
backport to stable16 in #1947 |
Member
|
@nickvergessen The compatibility test fails with |
Member
Author
|
It's compliance, not compatibility ;) Accepted risk, we could disable the check altogether, but we can have a look at it now and then. |
Member
Author
|
Nevermind, see #1951 for a fix |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1872