Fix audio not played before video is received in Chromium - #2035
Merged
nickvergessen merged 1 commit intoJul 31, 2019
Merged
Conversation
Chromium does not play the audio in a video element before the video is available. Due to this, when the remote peer had audio and video available if both were disabled (for example, when the remote peer has just joined the call) and then the audio was enabled the audio from the remote peer was not heard in Chromium until the video was also enabled. Instead of using a video element for both the audio and the video now an audio element was added to play the audio tracks of the remote stream. The change is applied to all browsers, though, as using an audio element for the audio tracks makes sense in all of them (even if until now they worked fine except for Chromium). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: WebRTC 🚡
Member
Author
|
/backport to stable16 |
delete-merged-branch
Bot
deleted the
fix-audio-not-played-before-video-is-received-in-chromium
branch
July 31, 2019 09:03
|
backport to stable16 in #2058 |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium does not play the audio in a video element before the video is available. Due to this, when the remote peer had audio and video available if both were disabled (for example, when the remote peer has just joined the call) and then the audio was enabled the audio from the remote peer was not heard in Chromium until the video was also enabled. Instead of using a video element for both the audio and the video now an audio element was added to play the audio tracks of the remote stream.
The change is applied to all browsers, though, as using an audio element for the audio tracks makes sense in all of them (even if until now they worked fine except for Chromium).
How to test
*It seems that old Firefox versions did not even send a black stream until the video was enabled for the first time, so there was no video track and the audio was played without problems in Chromium.
Result with this pull request
The audio from the owner is heard in Chromium.
Result without this pull request
The audio from the owner is not heard in Chromium; if the owner enables the video then the audio is also heard.