🔢 Reorder and sort table columns by AndyScherzinger · Pull Request #2481 · nextcloud/tables

AndyScherzinger · 2026-04-14T21:37:36Z

Resolves #607 implementing the same mechanism views already offer, but for tables

Column Order: Added column_order to tables_tables (DB migration), extended the Table entity, TableService, and controllers to persist and apply it, and exposed a drag-and-drop ColumnOrderList.vue in the "Edit table" modal.
Default Sort: Added sort to tables_tables, wired it through the Table entity, TableService, and controllers, and added a DefaultSortRules.vue component to the modal.
Import/Export: Both fields are preserved through scheme export/import and user-migration, with round-trip tests confirming correctness.
Testing: Added / adapted unit up to e2e tests.
OpenAPI Spec: Updated and regenerated openapi.json and its TypeScript counterpart.

Dialog old	Dialog new (2 sort items)	Dialog new (1 sort item)	Dialog view new (2 sort items)

JSON Export
See last section for order/sorting block (like for views)

{
   "title":"Welcome to Nextcloud Tables!",
   "emoji":"\ud83d\ude80",
   "columns":[
      ...
   ],
   "views":[
      ...
   ],
   "description":"A B C D",
   "tablesVersion":"2.0.1",
   "columnOrder":[
      {
         "columnId":4,
         "order":1,
         "readonly":false,
         "mandatory":false
      },
      {
         "columnId":2,
         "order":2,
         "readonly":false,
         "mandatory":false
      },
      {
         "columnId":1,
         "order":3,
         "readonly":false,
         "mandatory":false
      },
      {
         "columnId":3,
         "order":4,
         "readonly":false,
         "mandatory":false
      }
   ],
   "sort":[
      {
         "columnId":3,
         "mode":"DESC"
      }
   ]
}

AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…able entity AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…table entity AI-assistant: GitHub Copilot v0.43.0, Claude Code v2.1.109 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

jancborchardt

Looks very nice! 2 things:

Wording detail: Heading should be "Default sorting" instead of "Default sort"
The default sorting can be deleted via the trash icon on the right. In Tables right now the default is new additions on the bottom, something we could also include there? That way it would be more obvious than being an "empty" state.

marcoambrosini

Nice one!
One comment about the info text of default sorting: I wonder if there's a way to make this explanation a bit more clear, I don't understand it 😅
Another minor improvement would be moving it to right after the heading instead of after the add rule button.

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

…ly if at least 2 sorting items are present AI-assistant: Claude Code v2.1.109 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger · 2026-04-16T12:10:37Z

Implemented @jancborchardt first comment and @marcoambrosini's feedback

jancborchardt

Noice

marcoambrosini

Thanks for the addition :)

…rent year for SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

blizzz · 2026-04-21T11:28:25Z

 	 */
 	#[NoAdminRequired]
-	public function createFromScheme(string $title, string $emoji, string $description, array $columns, array $views): DataResponse {
+	public function createFromScheme(string $title, string $emoji, string $description, array $columns, array $views, array $columnOrder = [], array $sort = []): DataResponse {


did not check further down the code, but $columnOrder and $sort are not tested or sanitized for expected input format.

blizzz · 2026-04-21T11:28:31Z

 	#[NoAdminRequired]
 	#[RequirePermission(permission: Application::PERMISSION_MANAGE, type: Application::NODE_TYPE_TABLE, idParam: 'id')]
-	public function update(int $id, ?string $title = null, ?string $emoji = null, ?string $description = null, ?bool $archived = null): DataResponse {
+	public function update(int $id, ?string $title = null, ?string $emoji = null, ?string $description = null, ?bool $archived = null, null|array|string $columnSettings = null, null|array|string $sort = null): DataResponse {


same here for $sort

blizzz · 2026-04-21T11:29:02Z

-	public function update(int $id, ?string $title = null, ?string $emoji = null, ?bool $archived = null): DataResponse {
-		return $this->handleError(function () use ($id, $title, $emoji, $archived) {
-			return $this->service->update($id, $title, $emoji, null, $archived, $this->userId);
+	public function update(int $id, ?string $title = null, ?string $emoji = null, ?bool $archived = null, null|array|string $columnSettings = null, null|array|string $sort = null): DataResponse {


blizzz · 2026-04-21T21:52:45Z

+			(int)$data[self::KEY_ID],
+			(int)$data[self::KEY_ORDER],
+			(bool)($data[self::KEY_READONLY] ?? false),
+			(bool)($data[self::KEY_MANDATORY] ?? false),


please revert this changes as well. It used to throw a PHP Error on construction, but now it silently succeeds with potentially flawed data.

blizzz · 2026-04-21T21:56:17Z

 	}
+
+	/**
+	 * @psalm-suppress MismatchingDocblockReturnType


blizzz · 2026-04-21T21:56:26Z

+	}
+
+	/**
+	 * @psalm-suppress MismatchingDocblockReturnType


I am also not entirely confident about the code generated here, but it is a bit vague gut feeling yet.

AndyScherzinger added enhancement New feature or request 2. developing Work in progress labels Apr 14, 2026

AndyScherzinger force-pushed the feat/607/reorder-and-sort-table-columns branch from 6d172fa to 8b814f8 Compare April 14, 2026 21:45

AndyScherzinger changed the title ~~Reorder and sort table columns~~ 🔢 Reorder and sort table columns Apr 14, 2026

AndyScherzinger force-pushed the feat/607/reorder-and-sort-table-columns branch from beb8965 to 57fb13d Compare April 15, 2026 10:30

AndyScherzinger added 4 commits April 15, 2026 12:45

feat(migration): add column_order and sort to tables_tables

d5cc9a8

AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

feat(tables): add column order and sorting on table-backend

c79bd78

AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

feat(tables): add column order and sorting on table-frontend

a62b53f

AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

docs(openapi): update openAPI for added column order and sorting on t…

3e89d2b

…able entity AI-assistant: GitHub Copilot v0.43.0 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger force-pushed the feat/607/reorder-and-sort-table-columns branch 3 times, most recently from 99efeb0 to 2c6d286 Compare April 15, 2026 12:57

test(tables): update e2e tests for added column order and sorting on …

f48f67b

…table entity AI-assistant: GitHub Copilot v0.43.0, Claude Code v2.1.109 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger force-pushed the feat/607/reorder-and-sort-table-columns branch from 8f572d9 to f48f67b Compare April 15, 2026 19:31

AndyScherzinger marked this pull request as ready for review April 15, 2026 20:35

AndyScherzinger requested review from blizzz and enjeck as code owners April 15, 2026 20:35

AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 15, 2026

AndyScherzinger requested a review from benjaminfrueh April 15, 2026 22:18

jancborchardt requested changes Apr 16, 2026

View reviewed changes

jancborchardt added this to 🖍 Design team Apr 16, 2026

jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Apr 16, 2026

jancborchardt requested a review from marcoambrosini April 16, 2026 07:28

samin-z self-requested a review April 16, 2026 08:02

marcoambrosini reviewed Apr 16, 2026

View reviewed changes

AndyScherzinger added 2 commits April 16, 2026 13:47

style(tables): Rephrase "Default sort" to "Default sorting"

0f00589

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

style(tables): Display sorting descriptive text below headline and on…

5cbb8a3

…ly if at least 2 sorting items are present AI-assistant: Claude Code v2.1.109 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

jancborchardt approved these changes Apr 16, 2026

View reviewed changes

AndyScherzinger requested a review from marcoambrosini April 16, 2026 16:33

marcoambrosini approved these changes Apr 17, 2026

View reviewed changes

samin-z requested changes Apr 17, 2026

View reviewed changes

Comment thread lib/UserMigration/TablesMigrator.php

Comment thread lib/Service/RowService.php Outdated

Comment thread src/modules/main/partials/editTablePartials/DefaultSortRules.vue Outdated

fix(tables): remove double-calling, consolidate db writes and use cur…

e26fd70

…rent year for SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

AndyScherzinger added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2026

AndyScherzinger requested a review from samin-z April 17, 2026 12:53

samin-z approved these changes Apr 17, 2026

View reviewed changes

AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2026

AndyScherzinger added this to the v2.1.0 milestone Apr 21, 2026

AndyScherzinger merged commit 2b330ef into main Apr 21, 2026
72 of 76 checks passed

AndyScherzinger deleted the feat/607/reorder-and-sort-table-columns branch April 21, 2026 10:25

github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Apr 21, 2026

blizzz reviewed Apr 21, 2026

View reviewed changes

AndyScherzinger mentioned this pull request Apr 21, 2026

Reordering validation #2505

Merged

blizzz reviewed Apr 21, 2026

View reviewed changes

Comment thread lib/Db/Table.php

}

/**

* @psalm-suppress MismatchingDocblockReturnType

Copy link
Copy Markdown

Member

blizzz Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red flag

blizzz reviewed Apr 21, 2026

View reviewed changes

Conversation

AndyScherzinger commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jancborchardt left a comment • edited by AndyScherzinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcoambrosini left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndyScherzinger commented Apr 16, 2026

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

marcoambrosini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

blizzz Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AndyScherzinger commented Apr 14, 2026 •

edited

Loading

jancborchardt left a comment •

edited by AndyScherzinger

Loading

marcoambrosini left a comment •

edited

Loading

blizzz Apr 21, 2026 •

edited

Loading