Conversation
AndyScherzinger
added
bug
blizzz
previously requested changes
Apr 21, 2026
AndyScherzinger
force-pushed
the
fix/noid/reorderingValidation
branch
6 times, most recently
from
2983cf5 to
ae472dd
Compare
blizzz
reviewed
Apr 24, 2026
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
We can take it, but it has still room for improvement,
AI-assistant: Claude Code v2.1.116 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…nd ViewColumnInfo object AI-assistant: Claude Code v2.1.116 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.116 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.116 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Claude Code v2.1.117 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
… callable in between AI-assistant: Copilot v1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot v1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
fix/noid/reorderingValidation
branch
2 times, most recently
from
7560fbe to
3efa881
Compare
Member
Author
|
Addressed all remaining comment, feel free to review again @blizzz |
blizzz
reviewed
Apr 24, 2026
…ccessors (getId(), getOrder()) This gives Psalm the concrete shape it needs while still avoiding any real logic duplication. array_merge() always produces a widened array<array-key, mixed> type in Psalm's eyes, so it can never satisfy a fixed-shape return type. AI-assistant: Copilot v1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…t necessary anymore Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
blizzz
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address post-merge feedback on #2481