🗃️ Structure import#2504
Draft
AndyScherzinger wants to merge 15 commits intomainfrom
Draft
Conversation
AndyScherzinger
added
enhancement
AndyScherzinger
force-pushed
the
feat/noid/structureImport
branch
6 times, most recently
from
4740f30 to
bca53a5
Compare
…rison AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ges atomically AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…er works The <input> was inside <template #actions> which gets unmounted when the menu closes. Moving it to the default slot keeps it in the DOM so .importStructureFileInput.click() can open the file picker. AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…rted {id} template
generateOcsUrl() does not support {id} placeholder substitution — it just
prepends the OCS base path. The literal string '{id}' was being included in
the URL, causing 404s silently swallowed by the catch blocks.
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…tations
StructureDiffService was returning a flat structure that ImportStructurePreview
was unable to render:
- tableMeta: was {changes: [{field, current, incoming}]}, now {field: {current, incoming}}
- columns add: was {action, sourceId, title, type, details}, now {action, column: <srcCol>}
- columns update: was {action, sourceId, targetId, title, type, changes: [{field,...}]},
now {action, targetId, column: {title, type}, changes: {field: {current, incoming}}}
- columns delete: was {action, targetId, title, type},
now {action, targetId, column: {title, type}}
- views add: was {action, title, details}, now {action, view: <srcView>}
- views update changes: was [{field, current, incoming}], now {field: {current, incoming}}
Updated StructureDiffServiceTest assertions to match the corrected shapes.
Also removed the :disabled guard that prevented Preview from firing without
a selected file — replaced with a showWarning call inside the handler.
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6)
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…ogic AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AI-assistant: Copilot 1.0.6 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/structureImport
branch
from
bca53a5 to
d6ec125
Compare
Contributor
|
hey @AndyScherzinger! Thank you for working on this. Really good feature that nice to have. Few points from my side:
|
Member
Author
|
Hi @Koc Thanks a lot for the testing and review. All very good points to look into and address. The clear identification of column would be neat to have and makes updating structures easier. Yet for existing ones some/improved heuristic drill might make sense, else you can't make use of this on legacy table structures but that could be a limitation to accept. Maybe. The colors aren't correct yet, first wanted to to get it working, right, polished. In that order and the current state is still very much in progress. The issues at the end are currently issues of default values that don't get exported but a target value gets computed, so a difference is detected... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for CI execution/checks