📊 feat(Analytics): enhance datasource#2554
Merged
Merged
Conversation
Rello
changed the title
Contributor
Author
|
Rello
force-pushed
the
feature/anayltics-datasource
branch
from
April 30, 2026 05:52
6711e27 to
affcbbe
Compare
Contributor
Author
|
Playwright tests are not relevant to this Analytics datasource |
AndyScherzinger
added
enhancement
enjeck
force-pushed
the
feature/anayltics-datasource
branch
from
June 15, 2026 16:35
5d57359 to
ec1a744
Compare
Signed-off-by: Rello <github@scherello.de>
Signed-off-by: Rello <github@scherello.de>
enjeck
force-pushed
the
feature/anayltics-datasource
branch
from
June 15, 2026 16:35
ec1a744 to
21ce9c5
Compare
enjeck
reviewed
Jun 15, 2026
| } | ||
|
|
||
| private function isMultiSelection(Column $column): bool { | ||
| return in_array($column->getSubtype(), [Column::SUBTYPE_SELECTION_MULTI, 'multi'], true); |
Contributor
There was a problem hiding this comment.
not sure we need the multi option
Contributor
Author
There was a problem hiding this comment.
it seems there was some usage so it looks like a legacy case
https://github.com/nextcloud/tables/blob/main/lib/Db/Row2Mapper.php#L477
Signed-off-by: Rello <Rello@users.noreply.github.com>
Contributor
Author
|
🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The datasource for the Analytics app is enhanced to provide more reporting capabilities:
countcolumn=1 is added for statistics in AnalyticsThe datasource now returns analytics-friendly scalar values for:
Unit test was added