Skip to content

Fix sort stars and select (#8) - #2835

Merged
enjeck merged 1 commit into
nextcloud:mainfrom
taiebot:Fix-Sort-Starts&Select
Jul 23, 2026
Merged

Fix sort stars and select (#8)#2835
enjeck merged 1 commit into
nextcloud:mainfrom
taiebot:Fix-Sort-Starts&Select

Conversation

@taiebot

@taiebot taiebot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
  • Fix sort order factor for number stars
  • Fix sort order in selectionCheck mixin

Fixes #2702

All the other columnstypes are like that one liner. This also remove discrepancy between public and private view when using preSort


🖼️ Screenshots

Showing ascending order 1,2,3,4

🏚️ Before 🏡 After
Screenshot 2026-07-21 at 21-40-23 Test sort - Tableaux - Nextcloud Screenshot 2026-07-21 at 21-07-11 Test sort - Tableaux - Nextcloud
Screenshot 2026-07-21 at 21-40-36 Test sort - Tableaux - Nextcloud Screenshot 2026-07-21 at 21-06-55 Test sort - Tableaux - Nextcloud

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@taiebot
taiebot requested review from blizzz and enjeck as code owners July 21, 2026 19:42
* Fix sort order factor for number stars

Signed-off-by: taiebot <dedreuil@yahoo.fr>

* Fix sort order in selectionCheck mixin

Signed-off-by: taiebot <dedreuil@yahoo.fr>

---------

Signed-off-by: taiebot <dedreuil@yahoo.fr>
@enjeck
enjeck force-pushed the Fix-Sort-Starts&Select branch from 79080d8 to 8647748 Compare July 23, 2026 17:58

@enjeck enjeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@enjeck
enjeck merged commit e505892 into nextcloud:main Jul 23, 2026
53 of 57 checks passed
@taiebot
taiebot deleted the Fix-Sort-Starts&Select branch July 26, 2026 12:46
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Star rating opposite sorting

2 participants