Skip to content

Migrate from Vue2 to Vue3 - #2836

Merged
enjeck merged 8 commits into
mainfrom
vue3-migration
Jul 23, 2026
Merged

Migrate from Vue2 to Vue3#2836
enjeck merged 8 commits into
mainfrom
vue3-migration

Conversation

@enjeck

@enjeck enjeck commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migrate from vue 2 to vue 3: #2767

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stableX.X
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@enjeck
enjeck requested a review from samin-z July 22, 2026 04:50
@enjeck enjeck self-assigned this Jul 22, 2026
@enjeck
enjeck requested a review from blizzz as a code owner July 22, 2026 04:50
@enjeck enjeck added the 3. to review Waiting for reviews label Jul 22, 2026
@github-project-automation github-project-automation Bot moved this to 馃Л Planning evaluation (don't pick) in 馃摑 Productivity team Jul 22, 2026
@enjeck enjeck added this to the v2.3.0 milestone Jul 22, 2026
blizzz
blizzz reviewed Jul 22, 2026
View reviewed changes
Comment thread package.json Outdated
blizzz
blizzz reviewed Jul 22, 2026
View reviewed changes

@blizzz blizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃コ did not test yet, green CI is promising

@blizzz
blizzz requested a review from a team July 22, 2026 09:21
@samin-z

samin-z commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

gaps found:

  1. route name assertion (like table -> tableContent)
  2. sort emits (.sync -> update:sort-entry change not validated)
    3.share permission toggle (no test for user share permission toggle, only public)

there is also a leftover :checked on NcActionButton in 'TableHeaderColumnOptions.vue' nothing big.

@enjeck

This comment was marked as outdated.

Sign in to view
@samin-z

samin-z commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@enjeck
number 1:
if route names arent tested and still reference old names like 'table' instead of 'tableContent', navigation by name silently fails or 404. users won't be able to reach tables via programmatic navigation.
number 2:
if sort emit is broken, sort changes will not be saved. if user sort the table, it'll revert on reload.

for 3 then i'll try to tests it manually.

@samin-z

samin-z commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@enjeck i checked all the points, everything works as they should so no need to look into them, everything except point 2 which is regarding sorting, after you sort and refresh the page, the previous selected sorting is gone.
i also checked it on main and it is working as it remembers previous state.
otherwise i also plaied around a little bit and everything was fine.

@enjeck

enjeck commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

i also checked it on main and it is working as it remembers previous state.

i checked on main and when I sort a view column, sorting clears when i refresh the page. Just like it does now

enjeck added 8 commits July 23, 2026 06:59
@enjeck
build(frontend): upgrade Vue 3 tooling
9c97357 
Assisted-by: Claude:claude-opus-4.8

Assisted-by: Codex:GPT-5
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
refactor(frontend): switch runtime to Vue 3
cee07e7 
Assisted-by: Claude:claude-opus-4.8
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
refactor(frontend): migrate components to Vue 3 APIs
845f364 
Assisted-by: Claude:claude-opus-4.8
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
refactor(export): use papaparse directly for CSV downloads
4eb5f54 
Assisted-by: Claude:claude-opus-4.8

Assisted-by: Codex:GPT-5
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix(tables): preserve sort edits and progress rendering
18c4618 
Assisted-by: Claude:claude-opus-4.8

Assisted-by: Codex:GPT-5
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
test(frontend): update tests for Vue 3
bf2576d 
Assisted-by: Claude:claude-opus-4.8
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: stylelint
0c47341 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@enjeck
fix: update dependencies and improve table sorting tests
5e1c347 
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
@samin-z

samin-z commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

i checked on main and when I sort a view column, sorting clears when i refresh the page. Just like it does now
you're correct, sorry it was on my side with the data i checked threw me off.

@enjeck

enjeck commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Holding off on merging until a release is done first. So vue 3 has time in main before the next release

@enjeck
enjeck merged commit 482b4c6 into main Jul 23, 2026
75 checks passed
@github-project-automation github-project-automation Bot moved this from 馃Л Planning evaluation (don't pick) to 鈽戯笍 Done in 馃摑 Productivity team Jul 23, 2026
@enjeck
enjeck deleted the vue3-migration branch July 23, 2026 17:56
@blizzz blizzz mentioned this pull request Jul 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz left review comments
@samin-z samin-z samin-z approved these changes

Assignees

@enjeck enjeck

Labels

3. to review Waiting for reviews AI assisted

Projects

馃摑 Productivity team
Status: 鈽戯笍 Done

Milestone

v2.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@enjeck @samin-z @blizzz