Skip to content

Check if attendeePin exists#1359

Merged
AndyScherzinger merged 1 commit into
masterfrom
bugfix/1314/attendeePinNPE
Jun 24, 2021
Merged

Check if attendeePin exists#1359
AndyScherzinger merged 1 commit into
masterfrom
bugfix/1314/attendeePinNPE

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Resolves #1314

Signed-off-by: Andy Scherzinger info@andy-scherzinger.de

resolves #1314

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the bugfix/1314/attendeePinNPE branch from a918aca to 0b49b65 Compare June 24, 2021 14:28
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1359-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings275275
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 141
Experimental Warnings 2
Internationalization Warnings 9
Performance Warnings 41
Security Warnings 4
Dodgy code Warnings 231
Total 440

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 141
Experimental Warnings 2
Internationalization Warnings 9
Performance Warnings 41
Security Warnings 4
Dodgy code Warnings 231
Total 440

@AndyScherzinger

Copy link
Copy Markdown
Member Author

successful test feedback: #1314 (comment)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable-12.1

@AndyScherzinger
AndyScherzinger merged commit 224c0b5 into master Jun 24, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the bugfix/1314/attendeePinNPE branch June 24, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crashs when pressing on participants of a conversation

3 participants