Skip to content

🎨 Server theming#2217

Merged
AndyScherzinger merged 58 commits into
masterfrom
feature/250/server-theme
Aug 11, 2022
Merged

🎨 Server theming#2217
AndyScherzinger merged 58 commits into
masterfrom
feature/250/server-theme

Conversation

@AlvaroBrey

@AlvaroBrey AlvaroBrey commented Jul 14, 2022 •
edited by timkrueger
Loading

Copy link
Copy Markdown
Member

Fixes #250

  • fix crash on initial, clean app launch when no user exists
  • fallback to xml provided colors in case no theme information from server available
  • grey theming for settings dialogs radio buttons (see files app for reference) Do this after moving SettingsController to an Activity implementation

Chat controller WIP:

  • Send button

  • Outgoing messages

    • Normal outgoing messages
    • File icons (folder and archive)
    • Audio
    • location links in outgoing shared locations

  • CREATE stable-14.2 BEFORE MERGING TO master

@AlvaroBrey AlvaroBrey added the 2. developing Work in progress label Jul 14, 2022
@AlvaroBrey
AlvaroBrey force-pushed the feature/250/server-theme branch 2 times, most recently from a4553f1 to b3e9ad3 Compare July 15, 2022 10:48
@nextcloud-android-bot

nextcloud-android-bot commented Jul 15, 2022

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings116116
Errors11

SpotBugs (new)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 15
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 61
Total 154

SpotBugs (master)

Warning Type Number
Bad practice Warnings 8
Correctness Warnings 35
Experimental Warnings 2
Internationalization Warnings 9
Malicious code vulnerability Warnings 15
Performance Warnings 22
Security Warnings 2
Dodgy code Warnings 61
Total 154

@AlvaroBrey
AlvaroBrey force-pushed the feature/250/server-theme branch 3 times, most recently from b1dec9c to a074870 Compare July 22, 2022 13:06
@AndyScherzinger
AndyScherzinger force-pushed the feature/250/server-theme branch 3 times, most recently from 1ad86ac to 392a5a4 Compare July 27, 2022 16:33
@nextcloud nextcloud deleted a comment from github-actions Bot Jul 27, 2022
@AndyScherzinger
AndyScherzinger force-pushed the feature/250/server-theme branch 3 times, most recently from 6a55047 to b705244 Compare July 28, 2022 15:08
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2022
@AndyScherzinger
AndyScherzinger marked this pull request as ready for review July 28, 2022 16:10
AndyScherzinger
AndyScherzinger approved these changes Jul 28, 2022
View reviewed changes

@AndyScherzinger AndyScherzinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AlvaroBrey 👍

@AndyScherzinger AndyScherzinger added this to the 14.2.0 milestone Jul 28, 2022
@AndyScherzinger AndyScherzinger changed the title wip: server theming Server theming Jul 28, 2022
@AndyScherzinger AndyScherzinger mentioned this pull request Jul 28, 2022
Closed
3 tasks
@AndyScherzinger

AndyScherzinger commented Jul 28, 2022

Copy link
Copy Markdown
Member

Follow-up issue for improvements is #2255

@AndyScherzinger AndyScherzinger changed the title Server theming 🎨 Server theming Jul 28, 2022
@AndyScherzinger
AndyScherzinger force-pushed the feature/250/server-theme branch 3 times, most recently from 49db567 to 7a04f1a Compare August 1, 2022 14:52
@AlvaroBrey AlvaroBrey self-assigned this Aug 1, 2022
AndyScherzinger and others added 20 commits August 10, 2022 19:21
@AndyScherzinger
don't tint status icons on cardViews
b9e9c35 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
theme all swipe to refresh layouts
e3c5357 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
set link colors correctly
96c2926 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
format layout
6e0afac 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Add caching
8f02558 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix entry menu bottom sheet input layout text color
6e42a52 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix input layout theming dark/light
23d436f 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
migrate profile fields to input layouts for Material3
b34765c 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
reuse color state list definitions
209c1a9 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
let current user be null-able
3c86536 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix binding changes
3a90092 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AlvaroBrey @AndyScherzinger
Make ColorUtil an injectable and clean up a little
a45166a 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey @AndyScherzinger
Move current user listening logic out of UserModule and into a new Cu…
a1a91c5 
…rrentUserProvider

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey @AndyScherzinger
ViewThemeUtils: move things that do not belong in this class
4abc383 
Color calculations go to ColorUtil, checking if dark theme goes to PlatformThemeUtil

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey @AndyScherzinger
ThemingCapability: remove obsolete TODO
eec323c 
it works

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey @AndyScherzinger
ViewThemeUtils: remove obsolete TODO
c817d09 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey @AndyScherzinger
Fix ktlint after rebase
501b753 
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AndyScherzinger
shorten number of return statements
11463ea 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
accept many functions within utility classes
65049b2 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
remove unused import
ddb033c 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the feature/250/server-theme branch from 2edd5f5 to ddb033c Compare August 10, 2022 17:24
@AndyScherzinger
remove unused resources and igonre unused quantities simply coming in…
df9e679 
… via transifex

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@github-actions

github-actions Bot commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2217-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger modified the milestones: 14.2.0, 15.0.0 Aug 10, 2022
timkrueger
timkrueger approved these changes Aug 11, 2022
View reviewed changes

@timkrueger timkrueger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on all my devices and in the emulator.

Very nice work @AlvaroBrey and @AndyScherzinger . Also the nice little improvements here and there 😍

@timkrueger

timkrueger commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

stable-14.2 is created.

I don´t merge this because the drone job is still running. Requested an abort.

@AndyScherzinger
AndyScherzinger merged commit ce71746 into master Aug 11, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the feature/250/server-theme branch August 11, 2022 07:47
@AlvaroBrey AlvaroBrey mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
+1 more reviewer
@timkrueger timkrueger timkrueger approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@AlvaroBrey AlvaroBrey

Labels

3. to review Waiting for reviews design Related to the design enhancement New feature or request feature: theming 🌗

Projects

None yet

Milestone

15.0.0

Development

Successfully merging this pull request may close these issues.

🎨 Support Server theme

4 participants

@AlvaroBrey @nextcloud-android-bot @AndyScherzinger @timkrueger