Dark theme

[dan0xii]

Initial work on a dark theme. There's still quite a bit of styling to do.
Closes #207.

• Conversation & information bubbles in the chat window need to be styled in dark mode.
• Emoji screen background is black, should match the chat window background colour.
• Conversation info screen has a black background when it should be dark grey to match the settings window.
• Long press on a conversation and the dialog at the bottom of the screen is not styled.

A couple of notes:

• The material library version 1.1.0-alpha02 and newer has a name conflict with TextFieldBoxes, see: CounterTextColor conflicting with material component library HITGIF/TextFieldBoxes#97
• Do I need to commit the .idea files? They're in my gitignore.

[mario]

I want to get rid of #407 TextFieldBoxes anyway as it's nothing but troubles :-/

[mario]

As for the idea files - don't kill the existing ones? :)

[mario]

As for the EmojiPicker, all the colors can be customized:

https://github.com/vanniktech/Emoji/tree/master/emoji/src/main/res

See values and values-night.

[dan0xii]

As for the idea files - don't kill the existing ones? :)

I don't know why that happened. :) I'll fix it.

[mario]

@dan0xii hey there! :) Do you need any assistance here?

[mario]

I have managed to remove the usage of TextFieldBoxes from one place, and failed to do so from the other (ServerSelectionController) due to theming issues, but it's a bit late so maybe I can try later :)

[thurloat]

I know this may be outside the scope of this, but it would be sick to match the colour scheme of the nextcloud install you're connected to. Or have an RGB colour picker for the window dressings and button colours.

[dan0xii]

@dan0xii hey there! :) Do you need any assistance here?

I've been caught up irl but I'll be working on this again now. Regardless, help wouldn't be refused. :)

[mario]

You came back @dan0xii and I went to a short vacation :) But still super happy to answer any questions you might have.

[dan0xii]

Hello Mario, I think this is ready for review now. There is probably a bit of cleanup to be done but I'd appreciate feedback on the theme. Thanks.

[mario]

HI @dan0xii thanks for the contribution. I'll take a look at this tomorrow with priority.

[mario]

Hi there. First of all, nice job but I did not expect anything less from you! :)

Few comments, as always:

• Conversation list -> conversation names are not really visible
• Inside a conversation - mentions inside a system message are not really visible
• There’s a similar issue with names if you type “@“ in the input box
• Could you look into the emoji thing? Because some of the emojis are really not visible on this particular background color
• For some reason, when in conversation, some messages have dark grey background, some white, some blue - why the three types?

I hope that’s enough for initial feedback, and I really can’t thank you enough for all the work you’re putting into this!

[dan0xii]

Conversation list -> conversation names are not really visible

How does this look? I've lightened up the text colour in dark mode.

Inside a conversation - mentions inside a system message are not really visible

How about this:

There’s a similar issue with names if you type “@“ in the input box

I'm working on this. The name_text TextView inside rv_item_mention.xml doesn't seem to adhere to system day-night mode.

Could you look into the emoji thing? Because some of the emojis are really not visible on this particular background color

Could you given an example?

For some reason, when in conversation, some messages have dark grey background, some white, some blue - why the three types?

I hadn't noticed this. It wasn't intentional and should now be fixed (see screenshot above).

What is the proper way to exchange data between controllers? I can't pick it up from their documentation. I'm thinking along the lines of how you'd use onActivityResult(). In SettingsController.java I'm calling getActivity().recreate() which doesn't apply to the conversation item header in the main conversation list so it may be that I need to call it again in that class. Hope that makes sense.

[mario]

@dan0xii looking into this now. Sorry for the delay.

[mario]

@dan0xii so I've justed tested changing the theme and it's changed in the main conversations list as well. Can you maybe screenshot the issue you're seeing? Conversation and settings are part of the same activity, so there should be no issues there.

As for emojis:

As for the mentions:

Do you think if a mention is black, it should have a white border? Unsure. What do you think?

[mario]

@dan0xii let me know if I can help in any way :)

[mario]

@dan0xii in your absence, I have temporarily taken over this PR :)

Changes done so far:

• rebased on master
• changed the way settings work:

On pre-28: Respect battery saving (default), light, dark
On 28 and up: Respect system settings (default), light, dark

• Updated dependencies so we don't need to recreate an activity anymore

So this leaves emojis issues and @ which I'll take a look into tomorrow, as well as conversation item. Would appreciate your review of my changes!

[mario]

Emojis panel issue has been solved by a switch to google emoji set via a different issue.

[mario]

This leaves the mention chips (once you mention somebody in a conversation) issue the only one standing.

[mario]

@dan0xii I'll go ahead and merge this. Once the master (you @dan0xii !) come back we can look into fixing any remaining issues, if any.

Thanks for all your hard work, you are awesome!