Edit mentions

[sowjanyakch]

🖼️ Screenshots

• Resolve Editing a message with mentioned users replaces them with these curly bracket tags. #4195

🚧 TODO

• ...

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[mahibi]

For me, it crashes with

Process: com.nextcloud.talk2, PID: 27437
java.lang.NullPointerException
	at com.nextcloud.talk.chat.MessageInputFragment.setEditUI$lambda$30(MessageInputFragment.kt:969)
	at com.nextcloud.talk.chat.MessageInputFragment.$r8$lambda$Utfaqgv7v4a77nbj_AuOP9YeTyQ(Unknown Source:0)
	at com.nextcloud.talk.chat.MessageInputFragment$$ExternalSyntheticLambda10.onClick(D8$$SyntheticClass:0)
	at android.view.View.performClick(View.java:8052)
	at android.view.View.performClickInternal(View.java:8029)
	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
	at android.view.View$PerformClick.run(View.java:31419)
	at android.os.Handler.handleCallback(Handler.java:1001)
	at android.os.Handler.dispatchMessage(Handler.java:105)
	at android.os.Looper.loopOnce(Looper.java:268)
	at android.os.Looper.loop(Looper.java:384)
	at android.app.ActivityThread.main(ActivityThread.java:8921)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:907)

when i mention someone

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	96	96
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	16	16
Dodgy code	61	61
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	94	94

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5072-talk.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

[sowjanyakch]

/backport to stable-21.1