Skip to content

[stable-21.1] Edit mentions#5134

Merged
sowjanyakch merged 17 commits intostable-21.1from
backport/5072/stable-21.1
Jul 8, 2025
Merged

[stable-21.1] Edit mentions#5134
sowjanyakch merged 17 commits intostable-21.1from
backport/5072/stable-21.1

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented Jul 8, 2025

Backport of PR #5072

sowjanyakch added 17 commits July 8, 2025 10:15
@sowjanyakch @backportbot
include mentions in edited message
977bca3 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
also get mentions from the input textfield
ea98a65 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
use mention name in edit text field
1e85be8 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
remove unused import
30a8fe4 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
move edit button on click listener to setEditUI
0486b28 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
editing mentions work
9a4e766 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
remove unused imports
77d0499 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
use mention chips in edit text
f50bcad 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
format code
24ffb45 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
suppress nested block depth warning
a98a8c5 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
remove nested block depth warning
d0e2892 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
check if message is null
bc0edc4 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
refactor
c729905 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
ktlint
1cdfdd6 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
hide mentionAutocomplete in edit mode
b8b101a 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
avoid crash if messageParameters is null
7eb765b 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch @backportbot
add replaceMentionChipSpans function
dfdb540 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@backportbot backportbot Bot added the 3. to review Waiting for reviews label Jul 8, 2025
@backportbot backportbot Bot added this to the 21.1.3 milestone Jul 8, 2025
@sowjanyakch sowjanyakch enabled auto-merge July 8, 2025 10:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

Codacy

Lint

TypemasterPR
Warnings9699
Errors010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total94100

SpotBugs increased!

@sowjanyakch sowjanyakch merged commit 2feffa0 into stable-21.1 Jul 8, 2025
13 checks passed
@sowjanyakch sowjanyakch deleted the backport/5072/stable-21.1 branch July 8, 2025 10:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 8, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5134-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi removed this from the 21.1.3 milestone Jul 29, 2025
@mahibi mahibi added this to the 21.2.0 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sowjanyakch sowjanyakch sowjanyakch approved these changes

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

21.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sowjanyakch @mahibi