Fix call state timing regression causing delayed audio routing#6092
Closed
alexey22p wants to merge 1 commit intonextcloud:stable-22.1from
Closed
Fix call state timing regression causing delayed audio routing#6092alexey22p wants to merge 1 commit intonextcloud:stable-22.1from
alexey22p wants to merge 1 commit intonextcloud:stable-22.1from
Conversation
Signed-off-by: alexey22p <potlov22@gmail.com>
alexey22p
force-pushed
the
fix-call-state
branch
from
d80d45e to
23bce92
Compare
Collaborator
|
Thank you @alexey22p we will have a closer look |
5 tasks
Collaborator
|
Thank you @alexey22p However i created #6103 and moved the stopCallingSound() outside of the Hope that's okay for you, it's just done in a separate PR as i want to move quickly forward. |
Author
|
Thanks, Mahibi, that makes sense. Moving stopCallingSound() separately is a cleaner minimal fix. |
AsherBond
pushed a commit
to AsherBond/talk-android
that referenced
this pull request
Apr 22, 2026
Some users complain about ringtone continuing to ring when a call is joined. It could not be reproduced but code wise it makes sense to call stopCallingSound here. This is adapted from the PR nextcloud#6092 Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch restores the original call initialization timing from 22.0.3.
In 22.1.x
prepareCall()was moved later behind permission checks and foreground service startup.As a result
currentCallStatus = IN_CONVERSATIONmay be set later than before.On some devices this can delay audio routing, speakerphone activation, or other call startup behavior.
Root cause
Regression introduced during call startup refactoring in 22.1.x.
Fix
Move
prepareCall()earlier to match the previous 22.0.3 behavior.Testing
Built locally and verified startup sequence changes.
Full push-notification based incoming-call testing could not be completed in the local build environment because Google push services were unavailable.
Regression comparison performed between: